Correct grammar for test messages in tracker.test

Updates per issue summary.

Most of the patch looks great, only one thing sticks out:

• $this->assertText('1 new', t('1 new comment is counted on the tracker listing pages.'));
• $this->assertText('1 new', t('1 new comment is counted on the tracker listing pages.'));

It isn't common practice to start a sentence with a number or to use the numerical representation of a number when it is less than ten. Should the '1 new comment' be changed to something like 'A new comment' (or 'One new comment' if an actual number is required)?

Looks like a good patch for the novice queue!

Updated patch based on suggestion in comment 2 (which makes sense).

Previous patch contains some diff noise, try this one instead.

updating tags

Tests don't need to use the t() function #500866: [META] remove t() from assert message anymore:

$this->assertNoText($unpublished->title, t('Unpublished node does not show up in the tracker listing.'));
...

should be:

$this->assertNoText($unpublished->title, 'Unpublished node does not show up in the tracker listing.');
...

We can do some cleanup in tracker.tests with this patch.

Same patch in #5 but without t() functions. I know that the removal of t() function is out of scope, feel free to review and commit the patch in #5.

#8: tracker-grammar-1338152-8.patch queued for re-testing.

Let's get these language clarifications out! It looks like this code is no longer in modules/tracker/tracker.test. That file no longer exists. I've updated this to run against the current 8.x drupal version, and it now modifies the /tracker/Tests/TrackerTest.php file, in which the t() functions were already taken out....

First change below is required to fix bad grammar. Second change is more "natural" sounding English but could be OK as is.

26,32c31,51
<      $this->drupalGet('user/' . $this->user->uid . '/track');
< -    $this->assertNoText($unpublished->label(), "Unpublished nodes do not show up in the users's tracker listing.");
< +    $this->assertNoText($unpublished->label(), "Unpublished nodes do not show up in the user's tracker listing.");
<      $this->assertText($my_published->label(), "Published nodes show up in the user's tracker listing.");
< -    $this->assertNoText($other_published_no_comment->label(), "Other user's nodes do not show up in the user's tracker listing.");
< +    $this->assertNoText($other_published_no_comment->label(), "Another user's nodes do not show up in the user's tracker listing.");
<      $this->assertText($other_published_my_comment->label(), "Nodes that the user has commented on appear in the user's tracker listing.");
---

I agree to mitron.

The #11 patch failed with following rejections

--- core/modules/tracker/lib/Drupal/tracker/Tests/TrackerTest.php
+++ core/modules/tracker/lib/Drupal/tracker/Tests/TrackerTest.php
@@ -72,14 +72,14 @@
));

$this->drupalGet('tracker');
- $this->assertNoText($unpublished->label(), 'Unpublished node do not show up in the tracker listing.');
- $this->assertText($published->label(), 'Published node show up in the tracker listing.');
+ $this->assertNoText($unpublished->label(), 'Unpublished node does not show up in the tracker listing.');
+ $this->assertText($published->label(), 'Published node shows up in the tracker listing.');
$this->assertLink(t('My recent content'), 0, 'User tab shows up on the global tracker page.');

// Delete a node and ensure it no longer appears on the tracker.
node_delete($published->nid);
$this->drupalGet('tracker');
- $this->assertNoText($published->label(), 'Deleted node do not show up in the tracker listing.');
+ $this->assertNoText($published->label(), 'Deleted node does not show up in the tracker listing.');
}

/**

I've redone the patch and included the suggestions from #12. Needs review!

I'm rerolling this patch.

The patch has been rerolled. Please review.

Looks okay for me and the patch applies right.