$new_node doesn't seem to be used in tracker.test
Remove it if it's not needed.

CommentFileSizeAuthor
#11 remove-unused-var-1338110-11.patch365 bytesoriol_e9g
#5 removing_unused_new_node_from_tracker_test-1338110-5.patch385 bytesaaron.r.carlton
#2 removing_unused_new_node_from_tracker_test-1338110-2.patch365 bytesaaron.r.carlton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Category: bug » task
Issue tags: +Novice

The tests pass with this removed - taging as novice

aaron.r.carlton’s picture

aaron.r.carlton CreditAttribution: aaron.r.carlton commented
FileSize
removing_unused_new_node_from_tracker_test-1338110-2.patch365 bytes

Just rolled a patch with the instance variable removed. That's all that is needed?

aaron.r.carlton’s picture

aaron.r.carlton CreditAttribution: aaron.r.carlton commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, removing_unused_new_node_from_tracker_test-1338110-2.patch, failed testing.

aaron.r.carlton’s picture

aaron.r.carlton CreditAttribution: aaron.r.carlton commented
Status: Needs work » Needs review
FileSize
removing_unused_new_node_from_tracker_test-1338110-5.patch385 bytes

Rolled off master, not 8.x version. Trying again.

aenw’s picture

aenw CreditAttribution: aenw commented
Category: task » bug
Status: Needs review » Active

@aaron.r.carlton re:#2 yup, that's all that's needed. I noticed this while doing #1315214: Clean up API docs for the tracker module and only had time to post the issue. Glad someone jumped on it. :-)

Looks good to me, but someone else should apply the patch and test it too, before it's moved to RBTC, just to make sure.

aenw’s picture

aenw CreditAttribution: aenw commented
Status: Active » Needs review

Somehow the status was changed to 'active' when I posted my comment. Should still be set to 'needs review'.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

It wasn't even used in the commit that introduced it: http://drupalcode.org/project/drupal.git/commitdiff/756131a862b3. Occurs in 7.x, too.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x, moving to 7.x for backport.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Version: 8.x-dev » 7.x-dev
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g commented
FileSize
remove-unused-var-1338110-11.patch365 bytes
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g commented
Status: Patch (to be ported) » Needs review
Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community

Thanks ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Oops. Nice catch!

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.