the attached patch adds the $user->access as "last_access" property

CommentFileSizeAuthor
#4 entity_user_last_access.patch1.67 KBdasjo
entity_user_last_access.patch1.21 KBdasjo

Comments

Status: Needs review » Needs work

The last submitted patch, entity_user_last_access.patch, failed testing.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Needs review 
+++ b/modules/callbacks.inc
@@ -305,6 +305,9 @@ function entity_metadata_taxonomy_vocabulary_get_properties($vocabulary, array $
+      return empty($account->access) ? NULL : $account->access;

Is the property sometimes FALSE? If so we need that, if it's just NULL or set we could go with the default getter.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

Tests fails...

@empty. we need it, but let's add a comment like that:

// In case there was no access the value is 0, but we have to return NULL.
dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Needs work » Needs review
StatusFileSize
new entity_user_last_access.patch1.67 KB

updated testUserProperties

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.