How to reproduce:

  1. Create 2 vocabularies (unique, required), with at least 1 term in each
  2. Create a node and assign it a term of each vocabulary
  3. Create a node based view with a related term relationship set as required and select only one of the 2 vocabulary

Result:
The clause for restricting to the specified vocabulary is missing, and the content is duplicated in the results.

CommentFileSizeAuthor
#1 views-vocabulary-skipped-when-term-relationship-required-1333702-1.patch827 bytesb-prod

Comments

b-prod’s picture

b-prod commented
Status: Active » Needs review
StatusFileSize
new views-vocabulary-skipped-when-term-relationship-required-1333702-1.patch827 bytes

This patch fixes the described issue.

dawehner’s picture

dawehner
Primary language German
commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Status: Needs review » Needs work 
+++ b/modules/taxonomy/views_handler_relationship_node_term_data.incundefined
@@ -49,6 +49,15 @@ class views_handler_relationship_node_term_data extends views_handler_relationsh
+      if ($vids = array_filter($this->options['vids'])) {

The filter is already executed above, what about reusing the variable?

Things like that are probably only fixed for 6.x-3.x

This issue doesn't matter for 7.x-3.x anymore, maybe 6.x-3.x should get a similar structure.

mustanggb’s picture

mustanggb commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)