it's awesome to be able to insert another view into the header and footer, love it!!!
It would be nice to have the list of views sorted alphabetical, that would make them easier to find.
Not a big deal but if you have a lot of views it would save time.

Thank you!

CommentFileSizeAuthor
#6 1331272.patch1.03 KBdawehner
#1 1331272.patch1.03 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
1.03 KB

Here is a patch for this.

mototribe’s picture

wow, that was really quick! Vielen Dank

I can't currently test it as I'm running rc1 and it doesn't seem to work there. Unless I'm not doing it right?

uwe$ pwd
/Users/uwe/Sites/mototribe03/sites/all/modules/views
uwe$ patch < 1331272.patch 
patching file views.module
Hunk #1 FAILED at 1385.
Hunk #2 FAILED at 1439.
2 out of 2 hunks FAILED -- saving rejects to file views.module.rej
dawehner’s picture

You have to use patch -p1

tim.plunkett’s picture

Triggering the testbot.

tim.plunkett’s picture

Status: Needs review » Needs work
+++ b/views.moduleundefined
@@ -1385,12 +1385,14 @@ function views_get_disabled_views() {
+ *  If TRUE, the list of views is sorted ascending. ¶

Trailing white space.

+++ b/views.moduleundefined
@@ -1385,12 +1385,14 @@ function views_get_disabled_views() {
+function views_get_views_as_options($views_only = FALSE, $filter = 'all', $exclude_view = NULL, $optgroup = FALSE, $sort = TRUE) {

Shouldn't this be FALSE by default?

dawehner’s picture

Status: Needs work » Needs review
FileSize
1.03 KB

Thanks for the review!

Next round of the patch.

dawehner’s picture

Status: Needs review » Fixed

Committed this patch with the change in views_handler_area_view.inc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.