If a module adds:

$form['favicon']['#collapsible'] = true;
$form['favicon']['#collapsed'] = true;

The favicon fieldset won’t collapse properly because the fieldset’s description is placed as a separate, un-wrapped 'markup' instead of a '#description' of the fieldset. This patch only changes $form['favicon']['text'] to $form['favicon']['#description'].

CommentFileSizeAuthor
#2 favicon-fieldset.patch1.07 KBZen
system_theme_settings.patch948 bytesjohnalbin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: 'Shortcut icon settings' not collapsible in system_theme_settings() » 'Shortcut icon settings' not using proper FAPI value

Fixed title to better represent what the patch does.

Zen’s picture

Zen commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new favicon-fieldset.patch1.07 KB

Well spotted :P Patch rerolled to sync with HEAD + form array split into multiple lines.

Setting to RTBC.
-K

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

drumm’s picture

drumm
he/him
Location NY, US
commented

COmmitted to 5.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)