Hello

If i create a page with views, displaying comments, i have no option to change the viewmode. Is it meant to be like this?
For nodes it works as supposed.

Cheers

Nexo

CommentFileSizeAuthor
#11 1330694-11-before.png16.97 KBstborchert
#11 1330694-11-after.png14.05 KBstborchert
#11 comment-viewmode--1330694-11.patch2.54 KBstborchert
#9 views_comment_view_modes_before.png54.62 KBaschiwi
#9 views_comment_view_modes_after.png59.67 KBaschiwi
#4 1330694-comment-viewmode.patch2.34 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Category: support » feature

Oh this sounds like a perfect feature request.

bfr’s picture

bfr commented

I think with 7.x everything should be treated as entities anyways, there should be no reason to have differ nodes from comments.

dawehner’s picture

dawehner
Primary language German
commented

Well this is the theory.

The reality says: there is no way to render an arbitrary entity, without entity api, so you still need special code for special entity types.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1330694-comment-viewmode.patch2.34 KB

This patch was proudly presented by "a long deployment phase".

Nexotap’s picture

Nexotap commented

Now im overhelmed. That was really fast.
Anway, I cant tell if the patch works as like patching, since 'patch' and 'me' are not swimming in the same river. But the code as such works. Pastet in everything manually and it works like supposed.

Nexotap’s picture

Nexotap commented

Now, since a new release of views came out, I'm wondering .... will this patch go into a release once?

dawehner’s picture

dawehner
Primary language German
commented

Well noone tested this patch yet. If you want to learn how to patch please google.

Nexotap’s picture

Nexotap commented

Just implemented the patch (Not just copied manually, patched like patching ) into release 7.x-3.0-rc3 and tested it.
Works as supposed.

aschiwi’s picture

aschiwi commented
StatusFileSize
new views_comment_view_modes_after.png59.67 KB
new views_comment_view_modes_before.png54.62 KB

Actually, Display Suite allows you to do this already. However I agree it would be better for Views to provide this functionality.

I tested this by creating a custom comment view mode using Display Suite. I then enabled the default comments_recent View. The patch applied cleanly on 7.x-3.0-rc3. Choosing a different view mode results in the display of the selected view mode, I tested it successfully in page and block displays.

My test is being done during the German Drupal Views Sprint, I will have someone else check the patch and set this to RTBC in case of success.

views_comment_view_modes_before

views_comment_view_modes_after

aschiwi’s picture

aschiwi commented
Issue tags: +dvcs11

Tagging.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new comment-viewmode--1330694-11.patch2.54 KB
new 1330694-11-after.png14.05 KB
new 1330694-11-before.png16.97 KB

Patch is working as expected.
I changed one minor thing: the label "Display links" (or "Hide links") is not valid anymore because we extend the settings form with the build modes.

before:
Label before patch 1330694-11

after:
Label after patch 1330694-11

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Oh that's cool! Commited to 7.x-3.x

Automatically closed -- issue fixed for 2 weeks with no activity.