JS initialization behavior execute multiple times

I wanted to change it again once all the whitespace thing got commited to use jquery once().

var localBehavior = 'xxx';
Drupal.behaviors['openlayers_behavior_' + localBehavior] = {
  attach: function (context, settings) {
    var data = $(context).data('openlayers');
    // you need data && or if will crash JS if data is empty
    var behavior = data && data.map.behaviors['openlayers_behavior_' + localBehavior];
    if (localBehavior) {
      $(context).once(localBehavior, function () {
        // func
      });
    }
  }
};

Abstracting away works too, but i'm not even sure that if (localBehavior) is even needed. I mean there are quite a lot of behaviors that don't even use the variable. so it could come down to :

// Add behavior method for OpenLayers
var localBehavior = 'xxx';
Drupal.behaviors['openlayers_behavior_' + localBehavior] = {
  attach: function (context, settings) {
    var data = $(context).data('openlayers');
    $(context).once(localBehavior, function () {
      // func
    });
  }
};

The problem could be if you have different maps with different settings on the same page.

But yeah I guess in the end abstracting is the way to go to shorten the code. I can work on a patch on top of the other one if you'd like.

updated patch. abstracted the thing like you said zzolo. it's so much better and shorter now.

Drupal.openlayers.addBehavior('navigation', function (data, behavior) {
  var options = {
    'zoomWheelEnabled': behavior.zoomWheelEnabled,
    'documentDrag': !!behavior.documentDrag
  };
  Drupal.openlayers.addControl(data.openlayers, 'Navigation', options);
});

and

(function($) {
  /**
   * Set default values and check that the behavior is applied once
   */
  Drupal.openlayers.addBehavior = function (behavior, attach, detach) {
    Drupal.behaviors['openlayers_behavior_' + behavior] = {
      attach: function (context, settings) {
        var data = $(context).data('openlayers');
        // need "data &&" to avoid js crash when data is empty
        var localBehavior = data && data.map.behaviors['openlayers_behavior_' + behavior];
        var that = this; // fix scope in attach
        if (localBehavior) {
          $(context).once('openlayers-' + behavior, function () {
            attach.apply(that, [data, localBehavior, context, settings]);
          });
        }
      },
      detach: detach
    };
  };
  
  /**
   * Adding a control is even shorter
   */
  Drupal.openlayers.addControl = function (openlayers, controlName, options) {
    var control = new OpenLayers.Control[controlName](options);
    openlayers.addControl(control);
    control.activate();
    return control;
  };
}(jQuery));

It's against 7.x-2.x of today i fixed a couple of leaking vars too.

the abstraction above is in a new file that i include in openlayers.render.inc with a simple

function _openlayers_behaviors_render($behaviors = array(), &$map = array()) {
  drupal_add_js(drupal_get_path('module', 'openlayers') . '/includes/behaviors/js/openlayers_behavior.js');
  // bla bla
}

It's not in the patch as i didn't know if it was the right place to add it.

happy now Mr. Bot ? :þ

Awesome, thanks :)

A little something got forgotten on the way