This will help with building dependency chains via Drush Make.

rules.make

; Drush Make (http://drupal.org/project/drush_make)
api = 2
core = 7.x

; Dependencies
projects[entity] = 1

Files: 
CommentFileSizeAuthor
#10 remove-make-file-1329346-10.patch246 bytesBassistJimmyJam
PASSED: [[SimpleTest]]: [MySQL] 258 pass(es).
[ View ]

Comments

fago’s picture

Component:Rules Core» Rules Engine

How does that interfere with possible existing make files (e.g. of distributions) that already include the entity api?

RobLoach’s picture

It doesn't break anything. Just sees it, and won't download it twice.

fago’s picture

Status:Needs review» Fixed

ok, then let's do it. Thanks, committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

seanberto’s picture

Status:Closed (fixed)» Active

If you have a makefile that already downloads Entity API and places it in a specific subdir, this dependency check breaks and the Entity API module is downloaded again. This is particularly problematic if you're initial makefile is pulling a specific tag of the Entity API module - and then the makefile in Rules pulls down a different version.

I know that this is technically a bug in Drush Make - but it's gumming up things here.

RobLoach’s picture

Hmm, that's a problem. Do you think we should move this issue over to Drush Make itself?

seanberto’s picture

Yeah. Sorry. In the meantime, selfishly, I'd love to see the Makefile come out of Rules so that it doesn't break the distro I'm working on...

I'll see Jonathan Hedstrom, the Drush Make maintainer, in just a few hours in Denver. I'll ping him on it.

jhedstrom’s picture

The problems you're experiencing are probably related to #1016924: Dealing with different versions of the same module in recursive makefiles.

BassistJimmyJam’s picture

I've run into this issue recently where the make file for my install profile downloads both rules and entity into a "contrib" subdirectory. As a result, when rules is downloaded it runs rules.make and I end up with an additional download of entity. I would like to see the make file removed until the issue with drush make can be resolved.

On a side not, the version number for entity in rules.make (1) is not valid.

BassistJimmyJam’s picture

Status:Active» Needs review
StatusFileSize
new246 bytes
PASSED: [[SimpleTest]]: [MySQL] 258 pass(es).
[ View ]

Attached a patch to remove the make file. If you add this to your make file it will be applied before drush looks for a recursive make file and avoid downloading entity again.

fago’s picture

Title:Add Drush Make dependency definitions (rules.make)» Remove Drush Make dependency definitions (rules.make)
Status:Needs review» Fixed

thanks, I've committed #10 as sadly #5 really is a dealbreaker.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrfelton’s picture

Good to see this removed. I think a kind of standard is to provide a .make.example file instead. But I dont really see that as needed here.