Closed (fixed)
Project:
Drush
Component:
Make
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
28 Oct 2011 at 21:22 UTC
Updated:
24 Dec 2011 at 00:50 UTC
Currently, Make has it's own built-in test suite. This needs to be ported to Drush's PHPUnit framework.
Comments
Comment #1
jhedstromInitial work on this has been done. The test makefiles have been moved into a
tests/makefilesdirectory.Related issue: #1325910: Speeding up the make tests
Comment #2
jhedstromAll tests are now passing (with the patch from #1331392: Allow calls to Drush_CommandTestCase::drush to pass in the expected exit code), except for the d.o.-specific plugin tests, which are currently commented out. These remaining tests that need to be ported are a bit trickier than the simple build tests.
Comment #3
jhedstromTests for d.o-specific functionality have been moved over to the new d.o drush project #1365484: Move drupal.org-specific functionality to drupalorg_drush project. However, I'm going to refactor the make tests so that each makefile gets its own test. As it is now, phpunit chugs along until it encounters a failure, then stops running the rest. Moving them into separate tests will allow people to quickly see how many makefiles are passing or failing.
Comment #4
jhedstromI just pushed up a commit that moves from a single test to 15 separate tests, so a single failure won't stop the rest of the make tests from running. AFAIK, these tests are now fully ported.