Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Oct 2011 at 15:50 UTC
Updated:
7 Sep 2025 at 12:07 UTC
Jump to comment: Most recent
Comments
Comment #1
gboudrias commentedAs a member of Koumbit and maintainer of platforms I would make sure the issues don't go unanswered. Note that in the end we didn't try to take the name "Platforms" in order not to monopolize the discussion / space for these kinds of projects.
(Edit: I'm also a programmer and I know enough about platforms and makefiles to fix things myself if need be.)
Comment #2
anarcat commentedI just want to give my +1 to this project - we've been working on those makefiles on the side for a long time, and I would be really happy if we had the opportunity to share our work with the community at last!
I can of course help with followup and issues that pop up.
Comment #3
klausiRemove LICENSE.txt, it will be added by drupal.org packaging automatically.
Not much to review here, PHP coding standards do not apply. Script code is nicely formatted, it does not seem to do any evil things. So I say RTBC.
Comment #4
j0nathan commentedI removed the file LICENSE.txt in the 3 branches:
http://drupalcode.org/sandbox/J0nathan/1317222.git/commit/ba7625a
http://drupalcode.org/sandbox/J0nathan/1317222.git/commit/f4e8048
http://drupalcode.org/sandbox/J0nathan/1317222.git/commit/335bb30
Thank you
Comment #5
gregglesThanks for your contribution, J0nathan! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.
Comment #6
j0nathan commentedThank you very much.
I promoted the sandbox project to a full project:
http://drupal.org/project/kplatforms
Comment #8
avpaderno