> The allowed domain, using the full path.example.com format. Leave off the http:// and the trailing slash and do not include any paths. Can only contain lowercase alphanumeric characters, dashes and a colon (if using alternative ports).

I assume they can contain a full stop too, since the example has one... ;)

CommentFileSizeAuthor
#9 1317138.domain.domain-name-allowed-chars-ui.patch1.63 KBagentrickard
#8 1317138.domain.domain-name-allowed-chars-ui.patch1015 bytesjoachim

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Postponed (maintainer needs more info)

WTF is a "full stop"?

What example?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)
joachim’s picture

joachim commented
Status: Closed (won't fix) » Active

Ok, 'period' in US english.

The example being 'path.example.com'.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

haha, good point.

Do we call that a period or a dot?

/me looks at the RFC

"Dot" is preferred.

When a user needs to type a domain name, the length of each label is
omitted and the labels are separated by dots (".")

https://www.ietf.org/rfc/rfc1034.txt

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

BTW: unless you use "localhost" at least one dot is required. So we might change the help text to indicate that.

joachim’s picture

joachim commented

Hmm ponder ponder. These are always tricky. How about:

"In addition to dots, can only contain lowercase alphanumeric characters, dashes and a colon (if using alternative ports)."

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

That's fine.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1317138.domain.domain-name-allowed-chars-ui.patch1015 bytes

Here's that in a patch.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1317138.domain.domain-name-allowed-chars-ui.patch1.63 KB

Minor change to wording and format. Committed to 7.x.3.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Committed to 7.x.2.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed

Applies to all three branches with fuzz.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.