The attached patch doesn't affect any functionality in the test cases, it just cleans up the code to conform to Drupal coding standards. Things that have been changed are:

1) Remove trailing whitespace.
2) Add newline character at end of file where missing.
3) Remove t() from array values in getInfo() functions.
4) Spelling corrections, especially "Take sure" -> "Make sure" in >30 places.
5) Use US spelling of "analyze" in all places - don't mix spellings.
6) Capitalize names of test classes in a uniform manner.

The patch is large, but should be easy to review because the changes are small and simple to understand - there are just a lot of them.

CommentFileSizeAuthor
#1 1316496-coding-standards.patch34.84 KBTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR’s picture

TR CreditAttribution: TR commented
Status: Active » Needs review
FileSize
1316496-coding-standards.patch34.84 KB

Patch attached.

TR’s picture

TR CreditAttribution: TR commented

Bump.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Reviewed & tested by the community

Why bump? That seems like a newbie thing to do, and you are not exactly a newbie :)

Anyway, the patch applies cleanly, and makes sense. Marking as RTBC.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! There are several big improvements here, especially the better grammar.
@bojanz You are right, there is no need to rush here.

There might be some people be interested in porting this back to 6.x-3.x to make it easy to test 6.x-3.x as well.

TR’s picture

TR CreditAttribution: TR commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Active
Issue tags: +Novice

The original patch was committed in a2859ed1c. But the issues have multiplied since then. In particular,

Spelling corrections, especially "Take sure" -> "Make sure" in >30 places.

was fixed in D7 with this patch, but since re-emerged in D7 and now there are 69 new occurrences of this phrase. Among other problems...

So I'm moving this back to D7 and marking it active. I'm not interested in making another patch, maybe someone else is.

Did I wait long enough to "bump" the issue this time?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Postponed
Related issues: +#2920737: Tidy up tests, coding standards

Lets get #2920737: Tidy up tests, coding standards committed first, then do this one.