API page: http://api.drupal.org/api/drupal/includes--theme.inc/function/theme_links/7

Describe the problem you have found:

attributes: (optional) Attributes for the anchor, or for the tag used in its place if no 'href' is supplied.

This needs to say that if class is supplied, it must be an array:

'attributes' => array(
'class' => array('colorbox-load'),
),

this will crash:

'attributes' => array(
'class' => 'colorbox-load',
),

Files: 
CommentFileSizeAuthor
#4 theme_inc-1314396-4.patch789 bytesrocket_nova
PASSED: [[SimpleTest]]: [MySQL] 33,616 pass(es).
[ View ]

Comments

jhodgdon’s picture

Issue tags:+Novice

Good idea, and probably a good project for a novice contributor.

joachim’s picture

Indeed, and could be copied from the docs for http://api.drupal.org/api/drupal/includes--common.inc/function/l/7.

rocket_nova’s picture

Assigned:Unassigned» rocket_nova

Working on this at BADCamp.

rocket_nova’s picture

Status:Active» Needs review
StatusFileSize
new789 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,616 pass(es).
[ View ]

Patch attached.

joachim’s picture

Status:Needs review» Reviewed & tested by the community

Looks good! :)

jhodgdon’s picture

Indeed, thanks!

catch’s picture

Version:8.x-dev» 7.x-dev

Thanks! Committed and pushed to 8.x, moving to 7.x.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.