The menu item access callbacks should use the "access content" permission rather than just TRUE.

There's a lot of text that comes from external sources and then gets stored and displayed without any filtering. From a security perspective, that information should be filtered on output.

I don't see a specific issue unless someone can alter the data coming in from the soap service so this doesn't need to block the application, but before making a release I suggest going through and adding check_plain or filter_xss appropriately. See http://drupal.org/writing-secure-code for details.

Comments

bdlangton’s picture

Status: Active » Closed (fixed)

Fixed the above issues. Thanks for pointing that out.

http://drupalcode.org/project/myfantasyleague.git/commit/99edd0c

greggles’s picture

Status: Closed (fixed) » Fixed

Awesome work - thanks!

Note that when you fix something the best Status is "fixed." This leaves it visible in the queue for two weeks at which point it gets automatically closed by an automated process.

Leaving it in the queue makes it visible to people who may be looking for the same issue and helps prevent duplicate issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.