While working on #1309392: Remove _form_set_class(), I noticed that we somehow missed a couple of these in node-rtl.css and in the Seven's CSS files. The original issue is here: #732914: Improve the markup/CSS for content and user filter forms. Here are the grep results:

Problem code

$ grep -r dl.multiselect .
./modules/node/node-rtl.css:#node-admin-content dl.multiselect dd .form-item label {
./themes/seven/reset.css:dl.multiselect dd,
./themes/seven/reset.css:dl.multiselect dd .form-item,
./themes/seven/reset.css:dl.multiselect dd select,
./themes/seven/reset.css:dl.multiselect dt,
./themes/seven/reset.css:dl.multiselect .form-item,
./themes/seven/style-rtl.css:dl.multiselect dt,
./themes/seven/style-rtl.css:dl.multiselect dd {
./themes/seven/style.css:dl.multiselect dt,
./themes/seven/style.css:dl.multiselect dd {
./themes/seven/style.css:dl.multiselect select,
./themes/seven/style.css:dl.multiselect dd select {

How to fix

  1. This code no longer exists in Drupal 7 or 8. It can be safely deleted, and backported to Drupal 7.
  2. The #node-admin-buttons was part of this, so the entire node-rtl.css should be deleted in this patch.
#3 remove_multiselect_1311490_3.patch1.79 KBskottler
PASSED: [[SimpleTest]]: [MySQL] 33,320 pass(es). View
#1 remove_multiselect_1311490.patch1.75 KBskottler
PASSED: [[SimpleTest]]: [MySQL] 33,329 pass(es). View


skottler’s picture

Status:Active» Needs review
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 33,329 pass(es). View

I've attached a patch to remove all the instances of dl.multiselect.

Jacine’s picture

Status:Needs review» Needs work

Thank Sam!

Just gotta delete node-rtl.css cuz of this #node-admin-buttons (it's also gone), and this will be good to go!

skottler’s picture

Status:Needs work» Needs review
new1.79 KB
PASSED: [[SimpleTest]]: [MySQL] 33,320 pass(es). View

I've attached the node-rtl.css file. This change is reflected in the new patch.

This patch also applies cleanly to D7 head.

Jacine’s picture

Status:Needs review» Reviewed & tested by the community

Great, thanks Sam! Looks good.

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 7.x and 8.x. Thanks! Good catch.

Automatically closed -- issue fixed for 2 weeks with no activity.