Inline diff not rendered [#1310422]

Comment	File	Size	Author
#1	diff-1310422-fix-inline.patch	1.21 KB	skwashd

Comment #1

skwashd CreditAttribution: skwashd commented 15 October 2011 at 02:03

Status:

Active

» Needs review

File	Size
diff-1310422-fix-inline.patch	1.21 KB

The attached patch fixes this problem.

Log in or register to post comments

Comment #2

Deciphered CreditAttribution: Deciphered commented 20 October 2011 at 06:52

@skwashd,

Can you please explain this patch, or at least provide some reproduction details, as the change itself seems redundant as it's simply replacing one ID with another, unless there are other places where the new ID is being used, or if the first ID is being nuked somehow.

At a glance, the patch makes no sense to me, but I'm happy to be shown the error in my ways.

Cheers,
Deciphered.

Log in or register to post comments

Comment #3

skwashd CreditAttribution: skwashd commented 21 October 2011 at 13:33

The current element id for the ajax wrapper never exists in the page and so the request is made, the diff content is returned it is never injected back into the page as the target isn't there. This patch uses the standard Drupal node element id as the wrapper so it can be replaced by the ajax response.