Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have seen a couple of instances of duplicate activity log messages on fairly OOB Commons installations. See the attached screenshots. At this time I am not sure whether this is due to a misconfiguration in Commons or whether it is a bug in the Acticity Log module.
Comment | File | Size | Author |
---|---|---|---|
#20 | activity-log-group-node-duplication-1306252-20.patch | 6.5 KB | IceCreamYou |
#20 | activity-log-group-node-duplication-simple-1306252-20.patch | 684 bytes | IceCreamYou |
#18 | 1306252-activity_log_node_og_dupes-b.patch | 48.49 KB | ezra-g |
#17 | 1306252-activity_log_node_og_dupes.patch | 90.31 KB | ezra-g |
#15 | ezra | AL Test.jpg | 87.51 KB | ezra-g |
Comments
Comment #1
cpliakas CreditAttribution: cpliakas commentedSearch fail. Might be a duplicate of #1256642: Duplicate status updates. Marking as postponed, because I am sure you need more info.
Comment #2
lightsurge CreditAttribution: lightsurge commentedI'm seeing the same thing occasionally, regenerating the logs seems to clear it up (sometimes), but I can't figure out why it happens.
Comment #3
david.moore.ipg CreditAttribution: david.moore.ipg commentedIs it related to cross posting in multiple groups?
That said, it is annoying to get three messages about the same post that was assigned to three groups. Could the notification system not figure that out and send one notification? Or has that been fixes and I just don't have mine fixed?
Comment #4
cpliakas CreditAttribution: cpliakas commentedMarking as active since multiple people are seeing this issue.
Comment #5
lightsurge CreditAttribution: lightsurge commentedI'm guessing the patch at #1250820: The activity_log views should have a uniqueness filter probably will fix it though. Expect it'll be fixed in Commons as part of #1256076: Activity Stream modules are out of sync with Drupal.org
Comment #6
ezra-g CreditAttribution: ezra-g commentedI believe lightsurge is correct in #5.
Comment #7
mstef CreditAttribution: mstef commentedStill getting dupes with the latest activity stream and commons.
Comment #8
cpliakas CreditAttribution: cpliakas commentedI'm still getting them as of Commons 2.3 even after regenerating the streams. Haven't tested the bleeding edge code.
Comment #9
mstef CreditAttribution: mstef commentedContinuing the conversation started on #1272620: Remove unnecessary distinct from views, add caching to Views blocks about the dupes, here's something the scares me (see attached). 7 messages added for one node created.
Comment #10
mstef CreditAttribution: mstef commentedQuery showing the two duplicate messages in the attached image:
Focusing on the action_label.
Comment #11
ezra-g CreditAttribution: ezra-g commentedNote, cpliakas is using Commons 2.3, whereas mikesteff is using the 2.x dev version of Commons, which includes current versions of Activity log and related modules.
@mikesteff, if you haven't, might be worth doing a git pull on Activity log to make sure you're still up to date.
Comment #12
mstef CreditAttribution: mstef commentedI'm up-to-date on activity_log.
Comment #13
ezra-g CreditAttribution: ezra-g commentedIt seems that the messages are duplicated only for the acting user. For example - in the example below, cbrookins sees dupes of his own node creation message but egildesgame does not and vice versa.
As far as I can tell, there is no duplication of status messages.
Comment #14
ezra-g CreditAttribution: ezra-g commentedComment #15
ezra-g CreditAttribution: ezra-g commentedI was able to verify this behavior on a fresh installation of Activity log with Drupal 6.22, based on http://drupal.org/sandbox/ezrag/1329794.
Here's a screenshot from my fresh install.
Comment #16
ezra-g CreditAttribution: ezra-g commentedI was able to resolve the duplicates by removing "Log activity for the acting user" from this rule, since the acting user is a member of the group and therefore already sees this action logged.
I'm working on a patch to update the default rules. Hooray, enormous arrays :).
Comment #17
ezra-g CreditAttribution: ezra-g commentedComment #18
ezra-g CreditAttribution: ezra-g commentedThe previous patch accidentally removed a function definition.
Comment #19
IceCreamYou CreditAttribution: IceCreamYou commentedThanks for the patch -- just wanted to note that it's on my to-do list and after this is fixed I'll tag a new release (although I'd like to get in #1340600: UR Integration: Problem with non-approved statuses of non one way relationships showing up too if anyone has some bandwidth to test it).
Comment #20
IceCreamYou CreditAttribution: IceCreamYou commentedI guess this is still the only blocker for tagging a new release. The main reason I haven't gotten to this patch is because it's a much bigger patch than necessary and I can't tell what was added and removed. If all you did was remove the "Log activity for the acting user" action from the "Log activity when a node is created in a group" rule, wouldn't the first attached patch be enough? And if the problem is just that the acting user sees two activity messages, shouldn't the second attached patch be more appropriate?
Comment #21
ajayg CreditAttribution: ajayg commentedI tried only patch 2 as it was simple. I verified the original all four rules are no longer getting created as default.
Now only two rules appear
Log activity for members of the active group
Log activity for related taxonomy terms
so far so good. But when I created one activity, 2 messages for same activity still appeared. Earlier there used to be 3 messages per activity (one slightly different for group). This for the active user.
Now this was happening because there are indeed 2 rules. I created one activity (created a node in a group) and assigned into 3 more taxonomy terms. And it created 4 activity messages. One for node creations and 3 for each taxonomy terms. Is that expected? But then it is irritating even expected.
what is the reason "Log activity for related taxonomy terms" rule is required for group activity? What is the use case when this will be used? If not a common use case, we should remove from default rules.
Comment #22
IceCreamYou CreditAttribution: IceCreamYou commentedActually, this really should have nothing to do with what rules are defined. Activity Log includes a mechanism that ensures that only one activity message gets recorded for each event regardless of how many rules get triggered for that event. Apparently that is failing here. The patches in #20 were just to try to figure out what #18 is trying to accomplish.
Comment #23
Vilcoyote CreditAttribution: Vilcoyote commentedHello any news about this problem? I'm having it with version 2.4 of commons and it duplicates up x12 in one case (and more than 5 regularly).
I also checked this out from the point of view of a basic authenticated user and he also sees 12x duplicates of, for example, wiki page creation posted by someone else. So it isn't just a double line seen only by the creator of the content.
edit:
problem was solved. It was the same kind of problem. The message would be repeated for every tag added to a page (wikis, etc). Just remote the taxonomy rule and everything was fine.