#1208824: use 'views_ui_pre_render_add_fieldset_markup' for plugins added the helpful #fieldset option. But it's missing from most plugins:

grep -nr "parent::options_form" plugins | wc -l
17
ls -l plugins | wc -l
49

Plus, it's missing from views_plugin_style.inc itself.

Patch to come.

CommentFileSizeAuthor
#3 views-1297456-3.patch13 KBtim.plunkett
#1 views-1297456-1.patch10.8 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new views-1297456-1.patch10.8 KB

My grep counts weren't exact, not every plugin used options_form, and one of them was the original options_form(){}.

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Thanks for providing that patch!

Committed to 7.x-3.x
This probably makes sense to add to 6.x-3.x as well.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new views-1297456-3.patch13 KB

Here's the D6 version. But now that I look, this patch adds to the plugins in the /modules directory, I might have missed some for D7? I'll look into that tomorrow.

mustanggb’s picture

mustanggb commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)