It is time to update MAINTAINERS.txt to reality; I'm going to take a Drupal volunteer sabbatical for an undefined amount of time.

(please keep the issue focused on the patch).

Files: 
CommentFileSizeAuthor
#12 1293308-followup-12.patch441 bytesDavid_Rothstein
PASSED: [[SimpleTest]]: [MySQL] 41,295 pass(es).
[ View ]
#6 do-1293308-sabbatical.patch731 bytesHeine
PASSED: [[SimpleTest]]: [MySQL] 34,342 pass(es).
[ View ]
do-sabbatical.patch713 bytesHeine
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch do-sabbatical.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Comments

Everett Zufelt’s picture

Status:Active» Needs work

-- Heine Deelstra 'Heine'
+- The Drupal security team

I don't think we reference to an external source for team members anywhere else in the file, so at firt this doesn't seem consistent, not that this is necessarily a bad thing. The URL provided also doesn't list members.

Would it, perhaps, be better to make sure the list at https://security.drupal.org/team-members is up to date and then to include that list, or reference that list, in the file?

Heine’s picture

The page on d.o. provides much more information. The list on sec.do. is automatically generated and is linked to from the page on d.o.

Heine’s picture

Status:Needs work» Needs review

Would love additional feedback on the team vs. person.

Status:Needs review» Needs work

The last submitted patch, do-sabbatical.patch, failed testing.

Bojhan’s picture

@Heine I think the Security team lead should be there. This is for people, getting a quick overview who to contact. Although security team is the only truly recognized one, within Drupal. It creates another step for a contributor to find out who to contact, even from the link you send.

On another note, have fun with your volunteer sabbatical!

Heine’s picture

Status:Needs work» Needs review
StatusFileSize
new731 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,342 pass(es).
[ View ]

At the time of writing #0 there was nobody named yet. Here's an updated patch.

Thanks for the feedback and the wishes.

Status:Needs review» Needs work

The last submitted patch, do-1293308-sabbatical.patch, failed testing.

tstoeckler’s picture

Status:Needs work» Needs review

#6: do-1293308-sabbatical.patch queued for re-testing.

RobLoach’s picture

Status:Needs review» Reviewed & tested by the community

Have a great sabbatical, Heine!

webchick’s picture

Gosh I'm SO sorry this never got committed, Heine. :( :(

That patch didn't apply for me for some reason, but I made the changes manually to the 8.x, 7.x, and 6.x branches. Thank you so much for your excellent work. *salutes*

webchick’s picture

Status:Reviewed & tested by the community» Fixed
David_Rothstein’s picture

Status:Fixed» Reviewed & tested by the community
StatusFileSize
new441 bytes
PASSED: [[SimpleTest]]: [MySQL] 41,295 pass(es).
[ View ]

This patch was actually old enough that the URL formatting in that file changed in the meantime... (Applies to Drupal 7 also.)

So, here's a fix... just trying to get myself a couple cheap commit credits :) (Just kidding, there's actually no need to credit me on this commit.)

And thanks Heine!

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Duh. Thanks, David. I've no problem giving cheap commit credits to you! :D

Committed and pushed to 8.x and 7.x. 6.x is still using angle brackets, so I left that one alone.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.