If the checkbox to "Enforce Workbench Access control" is turned off for a content type, when editing nodes of that type, the "You must configure Workbench Access settings before editorial access control will be enforced" warning still appears. This should really not show up if the content type isn't under workbench access control.

CommentFileSizeAuthor
#5 workbench_access-enabled_node_types_ignored-1288944-4.patch1.06 KBmarcusx
#3 Workbench Access Workbench sandbox.png194.18 KBArgus

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Fair enough.

duellj’s picture

duellj commented
Status: Active » Closed (fixed)

Nevermind, sorry, just updated to the latest HEAD and see that it's fixed.

Argus’s picture

Argus commented
Status: Closed (fixed) » Active
StatusFileSize
new Workbench Access Workbench sandbox.png194.18 KB

I'm still getting this warning and I'm using all (WA, W, WM) the latest dev versions. Rebuilding access rights doesn't help. I tried all different settings, cleared cache, ran update.php, prayed to the gods.... but nothing helped.

See attached image for settings used.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yes, it looks like workbench_access_allow_form_alter() should be sensitive to node type settings.

marcusx’s picture

marcusx commented
Status: Active » Needs review
StatusFileSize
new workbench_access-enabled_node_types_ignored-1288944-4.patch1.06 KB

No idea if this is the right way to fix this but I needed this fixed and this solution is working for me at the moment.

I will mark the issue I opened #1421342: Deactivate access section dropdown on nodes where workbench access is not enabled as a duplicate.

Status: Needs review » Needs work

The last submitted patch, workbench_access-enabled_node_types_ignored-1288944-4.patch, failed testing.

marcusx’s picture

marcusx commented

Mmm the test fails cause of not finding "Section"

$this->assertRaw('Section', t('Workbench Access field was found.'));

Maybe the test is not prepared for handling a node with deactivated access. Can someone confirm that it is ok to change something on the test? I am not so into this testing stuff - but I think changing the test to make it pass needs a strong reason.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

It is ok to change the test. We should now have two tests:

* Does the field appear when it should?
* Does the field not appear when it shouldn't?

surandesilva’s picture

surandesilva commented

I was having a problem with WB Access ignoring the restricted Content Types setting. Applying this patch fixed the issue for me.

broeker’s picture

broeker commented

This problem also manifested itself recently on our site but in a slightly different way:

For testing purposes, I had temporarily disabled Workbench Access on the site (for unrelated reasons). When I re-enabled, suddenly I was getting the Workbench Access field on ALL content types regardless of the Content types enabled settings in config. When I applied this patch, the workbench access field started working properly again and no longer appears on nodes that are not enabled.

I never saw the warning to configure (per the op) but the problem definitely seems related, and is fixed by this patch.

dustin@pi’s picture

dustin@pi commented
Status: Needs work » Closed (duplicate)

Marking this as a duplicate of: #1797138: Section form element added to excluded content types

The commit accomplishes the same thing as the patch in 5.

Note: the patch still applies cleanly to 7.x-1.0+43-dev (October 6, 2012), as it contains a slightly different approach but it's redundant now.