Closed (fixed)
Project:
ShURLy
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2011 at 20:08 UTC
Updated:
14 Sep 2012 at 03:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
drupalnuts commentedpatch attached
Comment #2
traviscarden commentedAlthough I can understand why you might choose to put a non-required and perhaps little-used field after the submit button, I, too, feel like the submit button belongs at the end of the form to avoid confusion and promote consistency with other forms.
@drupalnuts, your code change, of course, does the trick. I tried your patch, however, and it didn't apply with
git apply. (It did withpatch -p0if I specified the file to patch.) I don't know why that was, but I re-rolled it and confirmed that the resulting patch applies properly. (I removed a little extraneous whitespace, too.) Find it attached below.By the way, @drupalnutes, remember to change an issue status to "needs review" when you upload a patch to make sure it gets attention. You might also check out Making a Drupal patch with Git to make sure your next one applies properly. :)
Comment #3
Mołot commentedI did it with custom module and form alter. It was, like, 10min work? So I agree it would be nice and I want it that way as well, but it can be fixed case-by-case without module patching.
Comment #4
quicksketchThanks guys! I've committed this pair of patches which implements your changes.