Comments

drupalnuts’s picture

StatusFileSize
new1019 bytes

patch attached

traviscarden’s picture

Title: Reorder create form so that it flows better » Move submit button to end of create form so that it flows better
Component: Code » User interface
Status: Active » Needs review
StatusFileSize
new1.29 KB

Although I can understand why you might choose to put a non-required and perhaps little-used field after the submit button, I, too, feel like the submit button belongs at the end of the form to avoid confusion and promote consistency with other forms.

@drupalnuts, your code change, of course, does the trick. I tried your patch, however, and it didn't apply with git apply. (It did with patch -p0 if I specified the file to patch.) I don't know why that was, but I re-rolled it and confirmed that the resulting patch applies properly. (I removed a little extraneous whitespace, too.) Find it attached below.

By the way, @drupalnutes, remember to change an issue status to "needs review" when you upload a patch to make sure it gets attention. You might also check out Making a Drupal patch with Git to make sure your next one applies properly. :)

Mołot’s picture

I did it with custom module and form alter. It was, like, 10min work? So I agree it would be nice and I want it that way as well, but it can be fixed case-by-case without module patching.

quicksketch’s picture

Status: Needs review » Fixed
StatusFileSize
new2.03 KB
new2.03 KB

Thanks guys! I've committed this pair of patches which implements your changes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.