Closed (fixed)
Project:
Video.js (HTML5 Video Player)
Version:
7.x-2.2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
6 Sep 2011 at 14:04 UTC
Updated:
8 Sep 2012 at 10:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
jasondecamp commentedsubscribe
I'm looking for a solution that works on a per video basis, not a global height and width setting (which is located in the module configuration area).
Comment #2
Jorrit commentedMaybe in a later version.
Comment #3
mogtofu33 commentedHi,
Thanks for this module, i need to set different width and height by field for different content type, so here is a patch to add this feature.
Regards.
Mog
Comment #4
michael.k commented@mogtofu33 you appear to be using 2.40 aspect ratio in your patch. I'm curious about your source format. Are you cropping from HD and then outputting a new file for upload, or are you transcoding directly from your source files?
Comment #5
mogtofu33 commentedI just use default values already set by videojs in admin settings.
Currently i am not using this module in production, i will probably have some user feedback when website will be launched...
Comment #6
michael.k commentedI see, thanks for the clarification.
@Jorrit then I'd suggest using a default value of 360 (instead of 264) for 'videojs_height' in videojs.theme.inc and videojs.admin.inc.
Comment #7
Jorrit commentedI have changed the default resolution and committed this patch. I have changed the patch such that it is possible to leave the field-specific form empty and get the default values. I also added some form validation. I hope you like the changes.