The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Minor whitespace fix. Also needs committed to Drupal 7. Applies cleanly to both.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | trailing-whitespace.patch | 264 bytes | tr |
| #4 | 1263882-2-authorize-php.patch | 1 KB | cweagans |
| #2 | 1263882-authorize-php.patch | 1.15 KB | tr |
| authorize_php_code_style.patch | 366 bytes | cweagans |
Comments
Comment #1
marcingy commentedLooks fine to me.
Comment #2
tr commentedThere's also blank space at the end of the script, and a few doxygen comments that needed tweaking for documentation standards. Modified patch fixes these. Applies cleanly to D8 and D7.
Comment #3
cweagansPer http://drupal.org/coding-standards#indenting, there is supposed to be an empty line at the end of files
Comment #4
cweagansNew patch.
Comment #5
tr commentedNo, that says last line should end with a newline, which my patch does. Before the patch, authorize.php ends with *two* newlines, which potentially causes the dreaded "Header already sent" error. There should never be a blank line at the end of any piece of Drupal code.
Comment #6
cweagansAh, you're right - I misread the patch. webchick, Dries: #2 is what should be committed
Also, FWIW, the "Header Already Sent" error wouldn't be caused by an extra empty line inside the scope of php. If you were to add a ?> and a new line after that, then you'd have the Header Already Sent error.
I'm going to set this back to RTBC. Again, this is for the patch on #2.
Comment #7
cweagansComment #8
webchickFixing tag.
Comment #9
dries commentedCommitted to 7.x and 8.x. Thanks.
Comment #11
tr commentedThe wrong patch was committed. See #6 where it says the correct patch is #2.
There is still a blank line at the end of authorize.php. Attached patch corrects this. Works for both D8 and D7.
Comment #12
dries commentedCommitted to 7.x and 8.x. Thanks.