Several core implementations of hook_nodeapi() have required 3rd parameters

tagging as Novice, since this is a really easy patch.

All core implenetations need to be checked, but upload_nodeapi(), trigger_nodeapi() and path_nodeapi() clearly have the problem.

I think this needs work - some of the changes add a 4th param (not needed) or change the name of the 3rd param:

-function comment_nodeapi(&$node, $op, $arg = 0) {
+function comment_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {

I think we don't need the change above at all. The main thing is to make sure that any 3rd or 4th params defined are optional (have a default value).

For example, I would change path_nodeapi() to:

function path_nodeapi(&$node, $op, $arg = NULL) {

I think it's fine for them to be 0 instead of NULL at this point - as long as there is a default value, it's optional.

ok, so the modified modules are:

modules/book/book.module
modules/forum/forum.module
modules/path/path.module
modules/translation/translation.module
modules/trigger/trigger.module
modules/upload/upload.module

Applied this patch, enabled all those module and did some basic functional tests. Didn't see (or expect) any errors.

Patch also looks good - minimal change to comply with the API and make 3rd and 4th params optional.

@gateway69 - no, it looks to be a corresponding bug in the views_attach module. Please file the bug there.