search input is too small. It can only fit 2 word phrases which is not enough. especially when you search content by "Advanced search".

CommentFileSizeAuthor
#15 search-input-width-1258342-15.patch1.09 KBAndreas Radloff
#5 screenshot.png23.75 KBrobloach
#5 1258342.patch438 bytesrobloach
#4 search.png27.09 KBdroplet
#4 search-input.patch1.21 KBdroplet
after.png13.37 KBdroplet
before.png13.21 KBdroplet
search_input.patch438 bytesdroplet

Comments

Bojhan’s picture

Bojhan commented

Yes, can we do a little bit less though?

droplet’s picture

droplet commented

sure. any suggestion ? now is the default size of 40 (300px)

robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

Instead of doing this with CSS, could we just change the #size of the textfield so that it applies to all themes rather than just Bartik's?

droplet’s picture

droplet commented
Title: Bartik search iniput is too small » Change search inputs' default width
Component: Bartik theme » CSS
Status: Needs work » Needs review
StatusFileSize
new search-input.patch1.21 KB
new search.png27.09 KB

Make sense, change it globally

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1258342.patch438 bytes
new screenshot.png23.75 KB

Does Bartik really need to specify the width itself? I don't see any reason why Bartik has to change it.

Status: Needs review » Needs work

The last submitted patch, 1258342.patch, failed testing.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review

#5: 1258342.patch queued for re-testing.

droplet’s picture

droplet commented

#5: 1258342.patch queued for re-testing.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

Looks good.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Which patch is RTBC? Both?

themesplanet’s picture

themesplanet commented

Yes sure you can change the width of search input through css. Take class of input search button and write the css for it.

droplet’s picture

droplet commented

@catch,

Patch #5: remove default style
Patch #4: remove default style and change form width (suggest from #1)

mukeysh’s picture

mukeysh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

change to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Hm. I think what's needed here is a patch that combines the two approaches. It sounds like what we want here is to set the size differently in the form element itself, and then also remove the custom CSS override of e.g. Bartik to not respect that.

This sounds potentially easy to do, so tagging as Novice.

Andreas Radloff’s picture

Andreas Radloff commented
Status: Needs work » Needs review
StatusFileSize
new search-input-width-1258342-15.patch1.09 KB

As requested by webchick, here's a patch combining:
1: remove width from Bartik search form css to make it wider.
2: Make search form smaller by setting width to 30 instead of forty on form element.

centas’s picture

centas commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +LONDON_2013_DECEMBER

Tested the patch, seems to be working fine and does combine both approaches mentioned.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.