Closed (fixed)
Project:
Drush
Component:
Base system (internal API)
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2011 at 18:33 UTC
Updated:
11 Feb 2012 at 15:12 UTC
Jump to comment: Most recent file
Comments
Comment #1
greg.1.anderson commentedHere is the same thing for 4.x, with an additional fix to allow
drush_invoke_process('@self', ...);again.Comment #2
moshe weitzman commentedSeems useful to me.
Do you think these embedded calls to pm-download should use --cache by default?
Could we add this to the site alias docs?
Comment #3
greg.1.anderson commentedRegarding docs, the alias topic just dumps examples/example.aliases.drushrc.php, which already has new docs in the above patches.
I think that the embedded call to pm-download should pass through the value of --cache. The easiest way to do this would be to add 'context' => 'DRUSH_CACHE' to the cache entry in
drush_get_global_options, just like NOCOLOR does. (Of course, we would have to set the context too.)I also think that cache should default to on always. However, shouldn't I perhaps commit #0 and #1, and handle cache changes as a separate issue? We can continue to discuss cache here if you prefer, though.
Comment #4
greg.1.anderson commentedThe wget package handler seems to cache invariantly, regardless of the setting of --cache. The git package handler creates a git reference cache if --cache is set. When pm-enable calls pm-download, it sets --cache, but this is the only place, and it seems unnecessary. If any changes are desired to the cache handling (beyond -removing- --cache from pm-enable's call to pm-download), it will take some consideration and discussion.
Comment #5
greg.1.anderson commentedCommitted #0 and #1 to master and 4.x, respectively.
Split off a new issue, #1260114: Cache handling.
Comment #7
greg.1.anderson commentedAdd "Needs change notification".
Comment #8
moshe weitzman commentedNo need for change record IMO