Line 854 of openlayers.module function options_form($defaults) should be function options_form($defaults = array()) or else Opelayers Plus doesn't work.

Comments

Adam S’s picture

Adam S commented

Bump. The OpenPublic distribution is going to need this patched in order to work since it uses OpenLayers Plus.

zzolo’s picture

zzolo commented
Category: bug » support

@Adam S, can you describe a bit why this is? I have used openlayers_plus module fine on D7. A patch would be cool if you have time.

Adam S’s picture

Adam S commented

What version of Openlayers Plus for D7 are you using? I'm using the version downloaded from the feature server for the OpenPublic distrobution on the Phase2 website. I'm going to have to create a website from scratch to test this again and should try to use what you are using.

zzolo’s picture

zzolo commented

I am using the developmentseed Github code:
https://github.com/developmentseed/openlayers_plus/tree/d7

I do get some warnings, but it worked fine the last time I tried.

Adam S’s picture

Adam S commented

The openlayers.module options_form($defaults) on line 854 requires an argument $default. All the openlayers plus behavior .inc files make a call to this function with options_form() failing to pass an argument. For example, in openlayers_plus_behavior_blockswitcher.inc on line 21 the parent class's options_form() is called without passing an argument. So one of two things need to happen. The openlayers plus modules .inc files need to add a $default variable to be passed to the openlayers.module function or the openlayers.module function needs a default argument such as function options_form($defaults = array())

zzolo’s picture

zzolo commented
Status: Active » Fixed

Well, the module should actually be able to work around the code, as its not really a bug. But its an easy enough fix. Committed. Thanks for digging deep into that one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.