Smart Paging seems to be causing a lot of erratic nl2br conversion issues with content bodies. About 90% of the time the body will load with proper formating, and then 10% of the time it will load as one big clump for no apparent reason.

Also, related to this issue, Smart Paging completely breaks the nl2br formatting for Comments, turning nicely formatted comments into unreadable blobs.

CommentFileSizeAuthor
#4 nl2br_weight_fix-1255420-4.patch923 bytesjamiecuthill

Comments

arpeggio’s picture

arpeggio commented
Status: Active » Postponed (maintainer needs more info)

It would help a lot if we have the actual content that is causing this issue and steps how to replicate it.

You may want to review the thread here: #1178906 as I posted there about loading as one big clump.

Routh’s picture

Routh commented


It would help a lot if we have the actual content that is causing this issue and steps how to replicate it.

You may want to review the thread here: #1178906 as I posted there about loading as one big clump.

The information in 1178906 is not related to my issue. The content body is being paged and converted correctly, the nl's are not being converted to br in the comments. This is some sort of issue with the replacement nl2br function.

As for examples, it's happening to all content on my site. ALL COMMENTS are showing as blobs on my site.

So for examples of the random issue, please visit any content on http://amateurwriting.net until you see it occur.

As for the comments, every comment on the site is doing it. As one example see the comment on this node. Please note that disabling the smart paging filter returns all comments to normal display. http://amateurwriting.net/writings/books/chronicles-albion-book-one-fool...

Routh’s picture

Routh commented

As an additional follow up to this, I have verified that the comment problem is related to the Smart Paging module by adding a text format that uses the core drupal nl2br and does not have smart paging enabled on it. Setting comments to this format fixes their output, however there is no way to limit the text formats on comments (that I have found) so correcting the issue with this module is still a major priority.

jamiecuthill’s picture

jamiecuthill commented
StatusFileSize
new nl2br_weight_fix-1255420-4.patch923 bytes

There is a problem with smart_paging_field_attach_view_alter which causes the autop filter to be skipped on fields with the same weight. Here is a patch to fix the problem by changing the way the fields array is built and sorted.

rickvug’s picture

rickvug commented
Status: Postponed (maintainer needs more info) » Needs review
arpeggio’s picture

arpeggio commented
Status: Needs review » Fixed

@jamiecuthil thank you for the patch. I have commit/pushed the patch. Please use the dev version.

Routh’s picture

Routh commented
Status: Fixed » Needs work

I have updated to the latest version, and I can confirm that this has corrected SOME of the affected fields, but it is not a complete fix yet. The standard comment body field is now being displayed correctly, however my site uses an additional comment field for 'corrections' which is still being affected. Please look at this entry on my site to see an example:

http://amateurwriting.net/comment/122

jamiecuthill’s picture

jamiecuthill commented

I've opened a new issue to discuss the autop filtering http://drupal.org/node/1294962

Just looking at that function gives me a headache, almost 300 lines is far too much!

I'm not sure why smart paging requires it's own autop filtering but it is causing a lot of problems as it doesn't do exactly what the filter module autop filter does due to the replacements happening only under certain conditions. The autop filtering should be moved out of the code that does the paging.

arpeggio’s picture

arpeggio commented
Status: Needs work » Fixed

I have already applied the patch of jamiecuthill from #1294962: Autop filter on comments and when view_mode is not full thread.

@Routh please update your Smart Paging with dev version and please check if your issue was fixed by jamiecuthill's patch.

Routh’s picture

Routh commented

@arpeggio sorry for the delay, I've updated and run tests. Looks like that's fixed everything. Thank you.

arpeggio’s picture

arpeggio commented

Good. Thanks Routh.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.