Needs review
Project:
Dingus
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2011 at 22:21 UTC
Updated:
1 Oct 2011 at 00:55 UTC
Jump to comment: Most recent file
the font size for h3 is larger than for h2
the code in the css is:
h3 {
font-size: 1.5em;
}
line 87
.node .content h2 {
font-family: "Franklin Gothic Medium","Arial Narrow Bold",Arial,sans-serif;
font-size: 1.25em;
line-height: 125%;
margin: 0.5em 0 1em;
}
line 762
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | h2andh3sizes-1254730-2.patch | 310 bytes | batigolix |
| #3 | Selection_007.png | 139.79 KB | batigolix |
Comments
Comment #1
yoroy commentedMight well be my lack of understanding git/version control, but I can't find this when I look at the download for 7.x-1.x-dev? (http://drupal.org/node/583310). I'd be glad to fix but can't reproduce. Thanks.
Comment #2
batigolixmy humble apologies: the line numbers I gave refer to version 7.x-1.2
in version 7.x-1.x-dev the line nrs are:
dingus.css line 757 for H2
and
dingus.css line 79 for H3
if I can figure out how to use Git I will send a patch ;)
Comment #3
batigolixI tried to create a patch (I'm not very familiar with git and the new patching), but I don't know if the result is OK from an aesthetic point of view.
See also the attached screenshot showing h2 and h3 in a the content region.
Comment #4
yoroy commentedThanks for digging and the patch! I think I committed something similar to your idea to 7.x-2.x just now. Lets see if I can make that branch show up on the downloads page. I'll see if I can add this change to 1.x as well…
Comment #5
yoroy commentedAFAIK I have a 7.x-2.x branch up here on d.o. but I can't see it or make it show up. I can't find these bits of css in the 7.x-1.x branch. If you used drush, I think it's like you actually downloaded 7.x-2.x. Could you try again please?
I may also have screwed up my version naming…