Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago’s picture

Status: Active » Needs review
FileSize
1.44 KB

Attached patch fixes it for me + improves hook_{ENTITY_TYPE}_delete() to receiver a further parameter, delete. Not sure whether we should do so or better set something like $entity->is_revert, analogous to $entity->is_rebuild.

fago’s picture

Status: Needs review » Fixed
FileSize
1.89 KB

I've further improved the patch so we don't need an extra parameter in the deletion hook, but can just check whether the entity is in code during deletion. For that to work also in the case of feature-module-disabling I've added an extra check, so that the status is updated before the deletion hook is invoked.

Thus, modules can just rely on the entity-status to figure out when it is a revert or not.

-> Patch remains working + tests are green -> committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.