Hey George,
I just noticed in my testing that the 'share' button/link (used to launch the social sharing widget) is not currently translatable to other languages. To fix, it looks like all we need to do is go to the line of code in rpx_widgets.module and wrap the word 'share' in a t().
Not only will doing this make the share button/link translatable to other languages, but site builders will also be able to modify the text itself using a module like String Overrides.
So it would be best to add this little fix sooner rather than later.
--Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | translateablesharebutton-1252704-3.patch | 784 bytes | infojunkie |
| #1 | translateablesharebutton-1252704-1.patch | 991 bytes | johnnydarkko |
Comments
Comment #1
johnnydarkko commentedHere's a patch. Hope this helps!
Comment #2
rafamd commentedComment #3
infojunkieWorks for me on D6. Just had to remove the second hunk which does nothing.
Comment #4
infojunkieComment #5
funana commentedWorks for me on D7. Thank you!
Comment #6
infojunkieComment #7
jim005 commentedsame for me. Working fine D7. thanks