wysiwyg problem with client side validation

Can you try the demos (http://atix.be/cv6a) and let me know if these work or not?

@igorik, can you try the demo's on your drupal install as well?

u can use git clone http://git.drupal.org/sandbox/jelles/1193994.git clientside_validation_example or use the zip in attach

you can find a sample form at /examplesform, i think it's in the navigation menu, but you can access it directly at www.example.be/examplesform

do you get any js errors in ie?

The problem was that when a submit button is pressed, wysiwyg editors get detached from their fields, so we had to reattach them if the form had errors. This should solve your problems.

Still seems to be an issue in the 7.x branch. Can you post the patch that was committed to fix this in 6.x, so that we can port it forward? (Or at least check that the changes are present in our copy...)

@kingandy can you provide more information about what modules/editors you're using? Are you using the latest version of this module?

We're using TinyMCE via the WYSYWIG module. We're on Clientside Validation 7.x-1.x-dev, I've just tested it on the latest roll (2011-Oct-15) and it's still occurring.

Actually, on review, this seems to be the reverse of the bug reported in this issue (in #11 - "the client validation message is shown, but
wysiwyg js from body textarea is disabled"). The behaviour that we're experiencing is that text added to a previously-blank rich text area is not detected by the validation script ... basically the content from TinyMCE's virtual text area is not being copied to the actual (hidden) text area before the validation triggers. The rich text editor remains in play, but the validator declares that the required field is empty.

Should I make a separate issue for this or is it related enough to stay here? It does seem to be the same sort of sequencing issue.

Fixed by making sure our code is executed after the wysiwyg javascript code

Can you post the patch that implemented the behaviour described in #14 ("we had to reattach [the rich text editors] if the form had errors")? We are genuinely not experiencing this behaviour.

The behaviour that we're experiencing is that text added to a previously-blank rich text area is not detected by the validation script ... basically the content from TinyMCE's virtual text area is not being copied to the actual (hidden) text area before the validation triggers.

Because we now make sure our code is executed after the code of the wysiwyg module the content from TinyMCE's virtual text area is already copied to the actual (hidden) text area before the validation triggers.

We do not have to reattach the rich text editor in 7.x because in wysiwyg.js of wysiwyg-7.x-1.x line 73-80 you will see:

// Detach any editor when the containing form is submitted.
$('#' + params.field).parents('form').submit(function (event) {
  // Do not detach if the event was cancelled.
  if (event.isDefaultPrevented()) {
    return;
  }
  Drupal.wysiwygDetach(context, params[format]);
});

Because Clientside Validation cancels the event if the form is not valid, the wysiwyg editor will not be detached and therefore we won't need to reattach it.

You can test it by downloading the latest dev from git or wait 12 hours until drupal.org updates the dev downloads on the project page

Cheers,
Jelle_S

Installed the latest 7.x-1.x-dev release. Content in rich text editor is now validating correctly, but we are now experiencing the behaviour described in #11 ("the client validation message is shown, but wysiwyg js from body textarea is disabled/hidden(all wysiwyg buttons disappear) and the content for this textarea is shown in html source").

Behavior confirmed and fixed with the same fix used for 6.x.

Confirm fixed in 7.x-1.20.