I'm working on a D7 port of this module. Patch coming

CommentFileSizeAuthor
#9 admin_message-d7-1247462-jelles-merge.do-not-use.patch16.26 KBdsnopek
#9 admin_message-d7-1247462-9.patch15.87 KBdsnopek
#3 1247462-3.patch17.1 KBJelle_S
#2 1247462-2.patch17.21 KBJelle_S
#1 1247462.patch17.18 KBJelle_S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Active » Patch (to be ported)
FileSize
1247462.patch17.18 KB

Patch to go from 6.x-1.x-dev to a Drupal 7 version attached

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Patch (to be ported) » Needs work
FileSize
1247462-2.patch17.21 KB 
+++ b/admin_message.jsundefined
@@ -1,13 +1,11 @@
+    $("#block-admin-message-admin-message a.admin-message-close").click(function() {

give the 'event' parameter to the function

+++ b/admin_message.jsundefined
@@ -1,13 +1,11 @@
       return false;

event.preventDeafault() rather than return false

fixed in attached patch

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
FileSize
1247462-3.patch17.1 KB

drupal_add_js and drupal_add_css api changes...

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented

sandbox for D7 created at http://drupal.org/sandbox/jelles/1254090

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Jelle_S: Are you still interested in working on a Drupal 7 port? If you update your code for the latest changes in the 6.x-1.x branch, I'd be happy to make a 7.x-1.x branch here and put your code in it. I'd do it now, but I'm worried about losing the functionality that was just merged.

JordanMagnuson’s picture

JordanMagnuson CreditAttribution: JordanMagnuson commented

Is any work being done on the Drupal 7 port at this point, or has the port been dropped?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

The patch that Jelle_S posted will still work against a 6.x-1.x-dev version from when the patch was written. However, that is missing many of the most current features of this module. As far as I know, no one is working on a Drupal 7 port. If you're interested in continuing Jelle_S's working and updating the patch for the latest features, I'd be happy to review and accept it.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I have admin_message.module working on a D7 website. I patched it to work with translation.module on a multi-language website (the same message in multiple languages, closing a message in one language closes the corresponding messages as well).

I'd like to provide the patches, but I cannot (black box) reverse engineer the changes from Jelle_S's patch against the current D6 feature set.

I'm afraid if you (dsnopek) are not interested in a D7 port, it will not be possible for another single person else to do the work and provide a patch.

A first step might be to open a 7.x branch and apply the patch provided by Jelle_S. And dsnopek delivers a list of features that should be ported to D7.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
admin_message-d7-1247462-9.patch15.87 KB
admin_message-d7-1247462-jelles-merge.do-not-use.patch16.26 KB

Through the magic of "git rebase" I've created a patch that combines the recent changes to 6.x-1.x and the changes in Jelle_S's sandbox. :-)

I also reviewed the patch a little bit and there were a number of things in it that I didn't think were quite right. So, I've also created an updated patch which I hope is better.

However, I haven't tested either of them!

@schoobidoo, Could you try this patch and see if it works? Once we can settle on a patch for D7, I'll create the 7.x-1.x branch and you can submit your multilingual patch.

FYI all the changes that were made since Jelle_S's last patch are in the Git log, which lists the specific issues in the issue queue:

So, for the record, I don't agree with this statement:

I'm afraid if you (dsnopek) are not interested in a D7 port, it will not be possible for another single person else to do the work and provide a patch.

Anyone who can operate git could have combined the changes or looked up which functionality I'm worried about losing. The real work is testing and finishing the port, which is something I'm not personally interested in working on at this time.

However, I will happily review and accept working patches!

JordanMagnuson’s picture

JordanMagnuson CreditAttribution: JordanMagnuson commented

Thanks for your work on this dsnopek. Would you mind releasing a 7.x-dev version of the module? Everyone should realize that a dev version is not to be used on a production site, but it seems like you might get more people testing out the module that way...

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

@JordanMagnuson: As soon as we settle on this patch, I will, definetyl! Right now, the latest patch is completely untested. So, either someone here please test it and let me know or I'll get around to it eventually. :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Issue summary: View changes

Updated issue summary.

igorik’s picture

igorik CreditAttribution: igorik commented
Issue summary: View changes

Bump!

Is there a chance to get the d7 version (at least patched file) for download?

thanks
Igor