Undefined index in domain_conf_default() [#1247452]

When implementing hook_domainconf(), it eventually adds a "settings" link to the default domain. This link goes to a special form domain_conf_default(). But in D7, the drupal_get_form invocation apparently changed, because I can see:

* Notice : Undefined index: sitename in domain_conf_default() (line 130 in domain/domain_conf/domain_conf.admin.inc).
* Notice : Undefined index: domain_id dans domain_conf_default() (line 143 in domain/domain_conf/domain_conf.admin.inc).

Comment	File	Size	Author
#5	1247452-domain-conf-form-state.patch	1.52 KB	agentrickard
#1	domain_1247452_7.x-2.x.patch	648 bytes	simon georges

Comments

Comment #1

simon georges commented 12 August 2011 at 12:26

Status:

Active

» Needs review

Status	File	Size
new	domain_1247452_7.x-2.x.patch	648 bytes

Please find the patch attached for 7.x-2.x-dev.

Comment #2

simon georges commented 12 August 2011 at 12:37

Status:

Needs review

» Needs work

Additionnal notes :
- the #default_value is not set, because the part with the call to $extra = domain_conf_api(); does not contain a $settings part (relative to the similar call for domains other than default), I'll try to provide a patch for this part as well later (but the patch above is useless if it doesn't allow to see the current value, actually :().
- the code is not the same in 7.x-3.x, settings values is discouraged for default domain, so the logic has changed for this part.