Gallery filter for image browser views [#1242704]

I want to make special Views filter allowing to select images only from specific gallery. The main idea is it should be used in exposed mode only, working in a "image browser" view types. It will show select element containing list of galleries of the current user, or all galleries list in a case of privileged user.
In summary, it will be similar to gallery selector on image edit form.
So is it good idea to make it as a patch to Node Gallery ? Will you accept it ?

Comment	File	Size	Author
#2	node_gallery_selector-1242704-2.patch	5.13 KB	crea

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

justintime CreditAttribution: justintime commented 8 August 2011 at 13:09

Sounds pretty cool -- I'd certainly commit it.

Comment #2

crea CreditAttribution: crea commented 9 August 2011 at 11:01

Status:

Active

» Needs review

File	Size
node_gallery_selector-1242704-2.patch	5.13 KB

Patch attached.

Comment #3

crea CreditAttribution: crea commented 9 August 2011 at 11:12

I've decided to drop support for privileged user browsing any user's albums. I think it wouldn't work because of number of albums. The select element would be too huge and unmanageble. I think different types of widgets are required for that task (Hierarchical Select, autocomplete, etc).

Comment #4

crea CreditAttribution: crea commented 13 August 2011 at 14:22

I've noticed small bug: when ajax is enabled and the filter is set to remember selection, when I use pager on initial view load, the gallery selector resets to the first option in the list. The default filter selection is not present in the URL at the first page load, and when I change page using AJAX, remembered filter selection is not working for some reason
If I disable AJAX, the bug disappears. I tend to think this is a bug of Views.
I've created a Views issue for this #1248332: "Remember" feature of exposed filters doesn't work with AJAX and is generally fragile

UPDATE: I've reproduced this bug with simple node view, without Node Gallery involvement.

Comment #5

crea CreditAttribution: crea commented 10 August 2011 at 08:43

Btw, this works wonderfully together with filter autosubmission from the Views Hacks project.

Comment #6

crea CreditAttribution: crea commented 13 August 2011 at 17:11

Note that this a very basic filter. I thought about adding more features to it such as filtering out empty galleries, but decided to not do it. We can't support every usecase anyway and the best thing we can do is to provide basic implementation. Advanced selectors could be implemented using this handler as a parent class.