I get this error when I edit an entity with an AddressField field:
String warning: Only variables should be passed by reference in addressfield_format_address_generate() (line 319 of sites/all/modules/contrib/addressfield/plugins/format/address.inc
That's the following line:
// Remove the prefix from the first widget of the block.
$first_child = reset(element_children($format['locality_block']));
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | addressfield-n1241134-2.patch | 1.11 KB | damienmckenna |
| #1 | addressfield-n1241134.patch | 658 bytes | damienmckenna |
Comments
Comment #1
damienmckennaAccording to the PHP docs the reset() function accepts a single argument as a reference, thus you can't daisy chain the returned data from element_children() to it. This patch should resolve the problem.
FYI the problem exists on line 338 in the current dev branch.
Comment #2
damienmckennaTurns out there was a second instance of the same statement elsewhere in the same file.
Comment #3
Rich_Weiss commentedI am getting the same error message. I did a fresh install of xampp and then installed commerce_kickstart-7.x-1.0-beta6-core. I then added one product to the shopping cart and tried to check out, at which point I received the error message. After patching the address.inc the error did not reappear, and I could complete the checkout process.
Comment #4
damien tournoud commentedThanks for the patch, committed.