Add tokens for workbench access sections

Seems reasonable. Shouldn't be very hard.

Patch?

That was my hope. This shouldn't take very long though, and should be ready for the 1.0 release.

Here's a patch. Well, not really a patch. Just rename the attached file workbench_access.tokens.inc and drop it in the workbench_access directory.

Seems to work. Could (maybe) use a test?

Will give this a test plus write some tests for this tomorrow!

It's there. If you're using taxonomy as the scheme, it should be [node:workbench_access].

You mean this #1191484: Workbench Access Views Contextual Filters, I assume. Otherwise, please open a new issue.

Here's the proper patch. To review the changes:

1. Only two tokens are needed: workbench-access-sections (section names keyed by access ID), and workbench-access-type. Using the array token type we now get [node:workbench-access-sections:keys] rather than having to implement [node:workbench_access_id].
2. Created a re-usable workbench_access_get_node_sections() functions to return a node's access section names keyed by access ID.
3. Fixed variable_get('workbench_access')'s default is actually 'taxonomy'.
4. Fixed [node:workbench-accesss-type] returns the machine name and not the actual name.

Just need to write some tests for this.

Don't we need the 'access_id' for people not using Token module?

I would think that most people (including the reporter) are most interested in the section names and not the IDs. I think for the purposes here it's perfectly reasonable to say "You can install the Token module to access the IDs as token to access [node:workbench-access-sections:keys]."

As a token system maintainer I'd prefer to avoid duplicating tokens wherever possible. If we did provide a [node:workbench-access-ids] token then it would not only be duplicating [node:workbench-access-sections:keys] but also adding more tokens and data to the token tree because of the additional token.

- Revised patch that moves/renames [node:workbench-access-type] to [site:workbench-access-scheme] as the access scheme is site-wide and not node-based.
- Also creates a access scheme token type so you can do [site:workbench-access-scheme:machine-name].
- Adds a [user:workbench-access-sections] token for the sections assigned to a user account.
- Includes tests for all tokens.

Todos:
- Add some tests for multiple-section nodes/users.

Niiiice.

Tests added for multi-section nodes and users.

Found a bug in that you cannot do the following:

$node = node_load();
$node->workbench_access = new array of ids();
node_save($node);

The problem is that workbench_access_node_save() fails if $node->workbench_access_scheme['access_scheme']); is not defined - which is true for any node loaded via node_load() since that property is added in the forms themselves.

There is also a variable mis-match. workbench_access_node_load() adds the section IDs in $node->workbench_access, while the form submission contains the IDs in $node->workbench_access_ids. A temporary measure has been added in workbench_access_node_save() until this can be resolved (separate issue will be filed).

Tests should be run against the full suite of tests to ensure I didn't regress anything because of the workbench_access_node_load() and workbench_access_node_save() changes.

Confirmed tests pass: 94 passes, 0 fails, 0 exceptions.

Let's commit this and then fix the other issue in a follow-up. It's non critical, even with the sloppy fix (and I say sloppy because the save function is badly designed, not because the fix is).

#17 has been committed to 7.x-1.x:
http://drupalcode.org/project/workbench_access.git/commit/760ab89
http://drupalcode.org/project/workbench_access.git/commit/6501f03

Thanks all for the testing and feedback.