update_sql() does not accept parameters as db_query(). The update_sql() in system_update_120() is thus a no-op.

Patch attached.

CommentFileSizeAuthor
#2 system.install-update_sql.patch_0.txt751 bytesRobrecht Jacques
system.install-update_sql.patch.txt753 bytesRobrecht Jacques

Comments

Robrecht Jacques’s picture

Robrecht Jacques commented
Component: install system » system.module
Robrecht Jacques’s picture

Robrecht Jacques commented
StatusFileSize
new system.install-update_sql.patch_0.txt751 bytes

Heine noticed on IRC that we probably should use %d instead of '%s' for the $alias->pid.

Patch attached.

Zen’s picture

Zen commented
Version: 5.x-dev » 6.x-dev

Unlikely, but are you sure that pid was not a string back when 120 was introduced?

-K

catch’s picture

catch
he/him
Primary language English
commented

This still applies with offset...

dries’s picture

dries commented
Status: Needs review » Fixed

I've committed this to CVS HEAD, however, it looks like the problem is still present in Drupal 5. I'll commit it to Drupal 5 as well.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.