the default is 10, but i think it's possible to be set to any decimal.

for now you probably want a value field in the main settings page, and also in the content type overrides.

CommentFileSizeAuthor
#4 conversion_value-1219344-4.patch6.73 KBfirebus
#3 conversion_value-1219344-3.patch6.73 KBfirebus
#1 conversion_value-1219344-1.patch6.1 KBfirebus

Comments

firebus’s picture

firebus commented
Status: Active » Needs review
StatusFileSize
new conversion_value-1219344-1.patch6.1 KB

here's a patch that adds a value to both the settings form and the node form

also, as i was writing the logic to display the correct value on the node form, i noticed that none of the values on the node form are respected. if you set a different label, color, etc. on the node form google_adwords ignores it and uses the values from the settings page.

i've fixed that here so that all values on the node form override the defaults on the settings form. the one exception is label - the existing logic suggested that the maintainers feel the label/path setting should override the node form label, and i've preserved that logic.

firebus’s picture

firebus commented
Assigned: Unassigned » firebus
firebus’s picture

firebus commented
StatusFileSize
new conversion_value-1219344-3.patch6.73 KB

I forgot to add value to the query string on the noscript img src.

I also wiped out a hook_update_n function by accident.

Here's a reroll that fixes these

firebus’s picture

firebus commented
StatusFileSize
new conversion_value-1219344-4.patch6.73 KB

one more try (variable name typo)

wiredescape’s picture

wiredescape commented

subscribe

Preston McMurry’s picture

Preston McMurry commented

The -4 patch appears to add a second color array below the one located approximately line 79 in google_adwords.install . Thought that might cause an error, so left that line out of my patch. Re-ran same test as previous. Noted the following line was added to the conversion javascript found in the page:

var google_conversion_value = 0;

(Or, "1.0", with quotes, if I had entered 1.0 as a value in the node edit.)

However, regardless of entered value, I did not see any line generated which looked like this bit, which google itself typically displays immediately after google_conversion_value's declaration:

if (1.0) {
  google_conversion_value = 1.0;
}

Note sure if that would cause a problem, though it would seem not.

Had no issues with it working in conjunction with color field ( http://drupal.org/node/1135348 ) and conversion code on non-node page patches ( http://drupal.org/node/1219306 ).

-----

Edit: Note that the missing javascript is mentioned here : http://drupal.org/node/1343232

perignon’s picture

perignon commented
Issue summary: View changes
Status: Needs review » Fixed

See 7.x branch for this change

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.