Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
file.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
12 Jul 2011 at 22:25 UTC
Updated:
29 Jul 2014 at 19:47 UTC
Jump to comment: Most recent file
Comments
Comment #1
jvc26 commentedPatch attempting to close this issue attached. Comments/review please.
Comment #2
jvc26 commentedCorrected patch - prior patch added a stylesheets reference to file.info, new one replaces the old reference to the stylesheet in file.module.
Comment #3
jyve commentedReviewed this patch, and looks good to me.
A patch for the image module css was added today, and I will advise there to also use base.css instead of admin.css so that these two modules are in line with each other.
Comment #4
xjmNote that this patch will need to be rerolled, because the core directory structure for Drupal 8 has now changed. (For more information, see #22336: Move all core Drupal files under a /core folder to improve usability and upgrades). Tagging as novice for the task of rerolling the patch. Set the status back to "needs review" when submitting the updated patch.
If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.
Comment #5
karschsp commentedHere's a re-roll for the /core move.
Comment #6
jyve commentedAfter some discussion in another issue #1216970: Clean up the CSS for Book module I would think all this CSS should go into a file.admin.css instead of file.base.css.
Comment #7
karschsp commentedHere's a re-roll.
Comment #8
karschsp commentedComment #10
karschsp commentedTrying again.
Comment #11
jyve commentedJust reviewed this patch and two things have been updated in the patch attached:
1. Added a file header in file.admin.css
2. Alphabetized the properties.
Comment #12
karschsp commentedLooks good.
Comment #13
catchLooks good to me too. Committed/pushed to 8.x.
Comment #15
miguelfrias commentedHow can contributed to this section?
Comment #16
oresh commentedReally small patch for selector weight reduce. Just to make core cleaner.
Comment #17
xjmCreate new issues, don't raise zombies.
Comment #17.0
xjmUpdated issue summary.