The book_export_html() function contains the following line:

$export_data = array();

But the $export_data variable is not referenced anywhere else in the function.

CommentFileSizeAuthor
#8 book_export_html-remove_unused_variable-1215404-D7.patch462 bytesbrianV
#3 book_export_html-remove_unused_variable-1215404-rev2.patch482 bytesbrianV
#1 book_export_html-remove_unused_variable-1215404-d6.patch916 bytespillarsdotnet
#1 book_export_html-remove_unused_variable-1215404-d7.patch916 bytespillarsdotnet
#1 book_export_html-remove_unused_variable-1215404.patch916 bytespillarsdotnet

Comments

pillarsdotnet’s picture

pillarsdotnet commented
Title: Remove cruft from book_export_html() » Remove assignment to unused variable $export_data from book_export_html() function.
Status: Active » Needs review
StatusFileSize
new book_export_html-remove_unused_variable-1215404.patch916 bytes
new book_export_html-remove_unused_variable-1215404-d7.patch916 bytes
new book_export_html-remove_unused_variable-1215404-d6.patch916 bytes

Patch.

pillarsdotnet’s picture

pillarsdotnet commented
brianV’s picture

brianV commented
StatusFileSize
new book_export_html-remove_unused_variable-1215404-rev2.patch482 bytes

Rolled to HEAD with no changes. Trivial patch, will RTBC once tests pass.

Status: Needs review » Needs work
Issue tags: -Needs backport to D6, -Needs backport to D7

The last submitted patch, book_export_html-remove_unused_variable-1215404-rev2.patch, failed testing.

brianV’s picture

brianV commented
Status: Needs work » Needs review
Issue tags: +Needs backport to D6, +Needs backport to D7

#3: book_export_html-remove_unused_variable-1215404-rev2.patch queued for re-testing.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Still good to go.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Love these. Committed/pushed to 8.x.

brianV’s picture

brianV commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new book_export_html-remove_unused_variable-1215404-D7.patch462 bytes

D7 patch

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Good to go.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/e0fa188

Automatically closed -- issue fixed for 2 weeks with no activity.