Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It would be nice to have the option of disabling these emails in the admin settings for the module.
Comment | File | Size | Author |
---|---|---|---|
#12 | og_mandatory_group_email_admin.patch | 6.49 KB | darren.ferguson |
#8 | contrib-5.og_man_group.admin-email.junyor.patch | 5.27 KB | Junyor |
#4 | og_mandatory_group_email_0.patch | 5.33 KB | geodaniel |
#3 | og_mandatory_group_email.patch | 5.34 KB | geodaniel |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedhmmm, yes this would be a relatively simple change. feel free to test and submit a patch.
Comment #2
geodaniel CreditAttribution: geodaniel commentedIt's on my long list of things to do, but as you say it's pretty simple, so I should be able to fit it in pretty soon :)
Comment #3
geodaniel CreditAttribution: geodaniel commentedAttached is a patch against 4.7 branch that will add this option (default is to email admins still). I've not tried out the 5.x version of this module yet, but I imagine a slightly modified version of the patch would be applicable there too.
Comment #4
geodaniel CreditAttribution: geodaniel commentedSorry, there was a typo in that from a last minute change. Latest version attached.
Comment #5
pwolanin CreditAttribution: pwolanin commentedI need to test this, still. Also, I'd suggest slightly different language for the settings form item. Something like:
Comment #6
pwolanin CreditAttribution: pwolanin commentedHmmm, maybe it should be more like:
Comment #7
geodaniel CreditAttribution: geodaniel commentedSure, sounds good to me - it makes it clearer who will receive the emails.
Comment #8
Junyor CreditAttribution: Junyor commentedUpdated patch to Drupal-5.
Comment #9
geodaniel CreditAttribution: geodaniel commentedThanks for the updated patch. It would be great to get this into the module.
Comment #10
geodaniel CreditAttribution: geodaniel commentedComment #11
geodaniel CreditAttribution: geodaniel commentedIt would also be good to get this into the D6 release, but the patch will need re-rolling as all the hunks fail.
Comment #12
darren.ferguson CreditAttribution: darren.ferguson commentedHave patched the d6 module for this functionality the patch is attached.
Comment #13
pwolanin CreditAttribution: pwolanin commentedplease double-check your patch. Looks like you made whitespace changes (e.g. line endings ) that amek it difficicult to see where the actual changes occur.
Comment #14
pwolanin CreditAttribution: pwolanin commentedComment #15
darren.ferguson CreditAttribution: darren.ferguson commentedI do not see any line endings in the patch, the reason for the changes is the if statement there that has moved everything on the patch.
Comment #16
tsi CreditAttribution: tsi commentedSubscribing, very wanted feature.
Comment #17
trjohnson CreditAttribution: trjohnson commentedWe are running a site and encounter a strange side-effect related to this topic. We have Real Name installed, when these emails are generated from the site the username gets translated into random text, e.g. 'zcpECkyaNK' instead of the normal username.
Being able to modify the notification would be wonderful, or baring that, being able to disable these messages would be helpful too.
Comment #18
mrtorrent CreditAttribution: mrtorrent commentedsubscribing
Comment #19
sreynen CreditAttribution: sreynen commentedThis looks good to me. The whitespace changes are necessary to maintain proper indenting inside the new if block.