rules_get_rule_set() calls variable_set() unconditionally on a cache miss, this could be avoid by checking the value of the variable prior to setting it.

Untested patch, should be able test soon though.

Files: 
CommentFileSizeAuthor
inactive_rules_variable_set.patch937 bytescatch
PASSED: [[SimpleTest]]: [MySQL] 13 pass(es).
[ View ]

Comments

fago’s picture

Component:Rules Core» Rules Engine

Patch looks good to me, any testers?

fago’s picture

Issue tags:+Performance

adding tag

catch’s picture

This is now running on a client site fwiw.

fago’s picture

Status:Needs review» Fixed

Thanks catch, committed.

Automatically closed -- issue fixed for 2 weeks with no activity.