Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
other project types
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Jul 2011 at 17:56 UTC
Updated:
7 Sep 2025 at 12:05 UTC
Jump to comment: Most recent
Comments
Comment #1
sreynen commentedMarking "needs review" so reviewers will see it.
Comment #2
ccardea commentedThe waiting time for a project application review is currently approaching six weeks. Please consider shortening your wait time by contributing to the code review process. All it takes is basic module writing skills, plus it is a great way to add to your knowledge of Drupal.Please visit http://groups.drupal.org/code-review for details on how to participate.
Comment #3
berkas1 commentedchanging to major according to the project application workflow
ccardea: thanks for your note about reviewing, i am learning php > when i'll learn the basic knowledge, i'll join the review group, but for now i don't have required knowledge:(
Comment #4
berkas1 commentedchanging to critical
thanks for review:)
Comment #5
berkas1 commentedNotes for new version - released today:
Fixed some bugs: repaired function for automatically re-running script
New function: user can set their own (number) values for memory_limit, max_input_time, max_execution_time, post_max_size, upload_max_filesize.... But if user doesn't want to set this values the script will provide its default values which are good for optimal server configuration.
Comment #6
klausiHave you tried to communicate with the aegir maintainers to include your code into the project? Joining forces is always better than to go your own way. Is there an issue where you asked aegir people for feedback?
Comment #7
berkas1 commentedi do not think that it could be added to aegir - because aegir installation is made by "apt-get install aegir" (debian package). So there is no way how to let user edit values like memory_limit, max_upload etc. - it needs external script.
I hope i described it well.
Comment #8
berkas1 commentedif there is no comment I am changing it back to needs review
Comment #9
klausiOur PHP coding standards do not apply to bash scripts, so I think this is good to go.
Comment #10
sreynen commentedHi berkas1,
Thanks for your contribution and welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects, at your discretion.
Now that you've experienced the full review process, please consider reviewing other projects that are still awaiting review. Anyone can help with reviews, following the guidelines.
Comment #11
sreynen commentedComment #13
avpaderno