On the Refers tab, the Referer column can run really wide if the offending referers are things like Google search result pages.

Wrap this column in a truncate_utf8() to truncate it with a trailing ellipsis.

CommentFileSizeAuthor
#4 pagenotfound_reports-1205892-4.patch620 bytesbenclark

Comments

BrockBoland’s picture

BrockBoland commented
Status: Active » Fixed

Committed this kind of by mistake with another issue.

BrockBoland’s picture

BrockBoland commented

Just realized this was also an issue on the All 404's list as well, and fixed it there too.

benclark’s picture

benclark commented
Status: Fixed » Needs work

I noticed there's a typo (?) in the commit related to this issue. Line 160 reads:

l(truncate_utf8($dblog->referer, 56, TRUE, TR), $dblog->referer),

Shouldn't the fourth argument in truncate_utf8 be TRUE? Very minor as it appears to not affect the output or produce an error.

benclark’s picture

benclark commented
Status: Needs work » Needs review
StatusFileSize
new pagenotfound_reports-1205892-4.patch620 bytes

See attached patch to fix the typo mentioned in #3.

BrockBoland’s picture

BrockBoland commented
Status: Needs review » Fixed

Yep, that was a dumb one. Patch has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.