Olá Lourenzo,

Eu re-escrivi completamente o projeto Boletophp, agora o código está no formato de biblioteca.
A biblioteca está hospedada em https://github.com/drupalista-br/Boleto/wiki/Projeto-Boletophp-API

Agora eu preciso integrar essa biblioteca ao Ubercat, entretanto ao invés de criar um novo módulo eu gostaria de juntar forças com você.

No momento estou escrendo outra biblioteca para a integração dos Cartões de Crédito Visa, Master Card e Dinners diretamente com a RedeCard (https://services.redecard.com.br/novoportal), através do API próprio deles, o http://www.komerciredecard.com.br .

Então considerando que estarei concentrado na RedeCard, seria bacana se você pudesse atualizar o UC Boleto para suportar a nova biblioteca do Boletophp mencionada acima.

Uma vez que eu concluir com a RedeCard o proximo passo será criar um modulo para o Ubercart que integrará a nova biblioteca da RedeCard. Dai nao dependeremos mais de gateways que cobram taxas enormes de nossos clientes.

CommentFileSizeAuthor
#18 uc_boleto.tar_.gz160.77 KBrfsbsb
#16 uc_boleto_erros.jpg158.44 KBbrunorios1
#14 uc_boleto.tar.gz154.63 KBrfsbsb
#7 boletolib-1203372-1.patch36.32 KBrfsbsb
#3 boletolib-1203372-1.patch36.12 KBrfsbsb

Comments

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
Assigned: Unassigned » rfsbsb

I'm implementing it right now. It's about 80% done and I sould send a patch in few more days.

FranciscoLuz’s picture

FranciscoLuz commented

Hi guys,

I've got the Commerce Boleto module ready for being tested. Please check it out at http://drupal.org/sandbox/drupalista-br/1256436 and send me your feedback.

Cheers,

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
Status: Active » Needs review
StatusFileSize
new boletolib-1203372-1.patch36.12 KB

Here is a patch for use of Boleto library mentioned.
Please review the english spelling.

This is a initial patch. I plan to implement the theme feature and a few other things.

FranciscoLuz’s picture

FranciscoLuz commented
Status: Needs review » Needs work

Hi Rafael,

Your patch was rejected. The reason for that is because it is trying to remove things that don't actually exist in the original files.

i.e. The uc_boleto.info bit tries to remove -dependencies[] = date_api but this text portion does not exist in the original uc_boleto.info

It is also trying to add things that already exist. i.e. The whole LICENSE.txt is being re-added by your patch and it causes rejection because there were no changes in it.

Don't forget also to run your code through the coder module http://drupal.org/project/coder to make sure your code complies with the standards.

Cheers,

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Francisco,

The patch was made upon the master repository, not on the 6.x branch.

FranciscoLuz’s picture

FranciscoLuz commented

Ow! My bad,

I am gonna try again. Sorry for that.

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
Status: Needs work » Needs review
StatusFileSize
new boletolib-1203372-1.patch36.32 KB

No problem...

But you have pointed something I missed, I haven't used coder module to check coding standard. Nothing critical just spacing issues...

Here is the post with these changes

FranciscoLuz’s picture

FranciscoLuz commented

Right,

Now its is patching fine.

In regard to the Nosso Numero field. I believe that each boleto must have a different number and not a pre fixed one, that is, it shouldn't be a admin option field for it. Please correct me if I got it wrong.

For Drupal Commerce I am sending the order number as Nosso Numero as well as Numero do Documento.

I will play around with that more later and get back to you with more comments on it.

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Francisco,

I'm not sure if it is the case for all banks. I haven't read anything about it yet. But I've just used the same implementation of the original.

If you find out anything different about it, let me know to modify it here too.

FranciscoLuz’s picture

FranciscoLuz commented
Status: Needs review » Needs work

I found this Q&A here http://www.neointerativa.com.br/_home/asp/Cobranca_Duvidas_Frequentes.as... that answers this question. So, nosso numero can not be the same for every boleto.

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Ah,

Ok Francisco. I'll fix it and post a new patch with these changes.

Thanks a lot for helping!

@lourenzo did you see this patch and some e-mails I've sent you?

brunorios1’s picture

brunorios1 commented

subscribing.

lourenzo’s picture

lourenzo commented

Rafael, please send me by e-mail a zipped folder containing your full module version, since git was not able to apply your patch here.

Thanks, and we'll coming to take this module's maintenance alive once again!

Regards.

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
Status: Needs work » Needs review
StatusFileSize
new uc_boleto.tar.gz154.63 KB

Hi lourenzo, here is the code in a zipped folder containing .git folder. This code also have the correction FranciscoLuz has mentioned.

lourenzo’s picture

lourenzo commented

Added to beta1 release, now we need testing.

brunorios1’s picture

brunorios1 commented
StatusFileSize
new uc_boleto_erros.jpg158.44 KB

Testei o módulo com o banco do brasil e encontrei alguns problemas:

1) não há campos para informar os números do contrato e do convênio (que influencia muito na formatacao do Nosso Numero e do codigo de barras)
2) o campo numero do documento fica sempre 0.
3) o campo nosso número fica sempre -0. além disso, ele está programado para ser formatado usando o "número inicial" mais o número da compra, porém a documentação do banco do brasil informa que o "nosso número" (no caso da carteira 18 e convenio de 7 digitos) deve ser formatado usando o numero do convenio seguido de um numero aleatorio.
4) seria legal criar um campo para informar a url do logo a ser usado no boleto.
5) alguns problemas com acentuacao no boleto:
Esp�cie
Ficha de Compensa��o
6) No cabeçalho do boleto, onde fica o endereço, não aparece a cidade, apenas estado e país.

anexei uma imagem para facilitar a verificação.

abraço!

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Thanks for your review Bruno.
I've only tested with bradesco and itau banks and forgot to test with Banco do Brasil e Caixa.
I'll fix these things and post a new patch.

Thanks again

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
StatusFileSize
new uc_boleto.tar_.gz160.77 KB

Hi bruno and lourenzo here is another version tested with Banco do Brasil, Caixa, Bradesco and Itau.

Of course it need more tests.

In order to work the logo field needs a modification on boleto-lib. I've already contacted FransicoLuz to fix it and as soon as it is applied the item should fix.

Please, review it.

brunorios1’s picture

brunorios1 commented

great! thanks for this!

the issues 1, 2, 3 and 4 (waiting for the modification on boleto-lib) of my last post was solved (very quickly!)

now, only need to fix the problem with the accents and the city, that's not displaying in the header ($cidade_uf).

thanks again!

FranciscoLuz’s picture

FranciscoLuz commented

Hi guys,

The logo thing seems to be an issue with boleto-lib which I have also encountered in Commerce Boleto. I will be looking into it sometime during this week as I still have to get my mind around to figure out what is going on.

Apart from that I don't think the other issues pointed out by Bruno at #16 have boleto-lib as their culprits. Please let me know if it turns out that boleto-lib is causing any of those other issues.

Cheers,

FranciscoLuz’s picture

FranciscoLuz commented

Hi,

The logo issue has been fixed. In case of any problem regarded to the logo not being loaded, please just re-open this issue here https://github.com/drupalista-br/Boleto/issues/9

Cheers,

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Yeah,

I've tested and it's now working with the latest version of boleto-lib. Thank you Francisco

Guys, please do more tests and if you think it's enough it can be changed to reviewed.

Thanks guys

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Hi guys any news about testing this patch?

I think if it's okay, someone should assign it as RTBC.

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented

Hi guys, any news?

Lourenzo, any idea if it will be rolled out?