DB2 Driver

Thumbs up for this project !

This is great! I believe Panels and CTools have been tested also and they work just fine.

Marking "needs review" so reviewers will see it.

This is the kind of thing we are really unlikely to get a review on. It requires setting up a DB2 database which is kind of hard to find in the community!

You need to remove the LICENSE.txt file.

Install.DB2.txt should be named INSTALL.DB2.txt

Please take a moment to make your INSTALL.DB2.txt follow the guidelines for in-project documentation.

Are the menu.inc and and install.inc and system.module meant to replace the files from core? That should be documented in the INSTALL file as well. I think a better solution is simply to provide a patch instead of replacement files. That way your patch can stay useful even if install.inc and menu.inc and system.module in core change.

It might be good to post into http://groups.drupal.org/database to try and get some reviews of the code.

Hi Greg,

Thanks for your time on reviewing this.

We will remove the Install.DB2.txt and have a README.txt containing the necessary info as per the doc guidelines.

>>It requires setting up a DB2 database which is kind of hard to find in the community!<<

Any particular difficulty you faced finding DB2. Users can download the free to develop/deploy and distribute edition of DB2, DB2 Express-C. http://www-01.ibm.com/software/data/db2/express/download.html?S_CMP=ECDD...

You mentioned to remove LICENSE.txt, any reason why a license file should not be present?

>>Are the menu.inc and and install.inc and system.module meant to replace the files from core?<<
Yes, these files need to replace the files from core. On your suggestion to patch it into core, Sure we will take this up as our next step.

Thanks

You should have a license for your code, but one is added for you by Drupal.org's packaging script so you don't need to add your own.

Regarding the difficulty of finding someone with db2, it's just that few people have already done that. We have a relatively hard time getting people with postgresql or mssql experience so it's nothing new, just a less common database (in this community) takes more time.

Have you looked at http://drupal.org/project/oracle or http://drupal.org/project/sqlsrv as a guide for how you can build this one?

Hi Greg,

Thanks for the feedback.

We have made changes to add README.txt and removed Install.DB2.txt, LICENSE.txt

>> Have you looked at http://drupal.org/project/oracle or http://drupal.org/project/sqlsrv as a guide for how you can build this one?<<

Our developer Deepthi had looked at these drivers for initial analysis and estimate for building the DB2 driver for drupal.

On your suggestion to post on http://groups.drupal.org/database, sure we will soon make a post requesting for review on this forum.

Thanks

P.S: Moving the status to needs review.

• It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
• "//DB2 database driver interface code for 0.0.1-beta version.": Remove this comment, any info on the file should be in the @file doc block. Don't hard-code versions in your source files, this is tedious to maintain. We have git fir that :-)
• db_status_report(): indentation errors for the array structure, the elements should be indented one level more. Use the coder module to check your code style http://drupal.org/project/coder
• db_connect(): general indentation errors, always use 2 spaces per level. Also elsewhere.
• db2_pmarker_normalexecute(): if/else constructs need to be always wrapped in "{}" even if they are just one liners
• lots of indentation errors everywhere - makes the code hard to read and understand. Please fix that.

@deepthivankadari has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact