I discovered this while working on hosting_services. Patch to follow.

Comments

sfyn’s picture

sfyn CreditAttribution: sfyn commented

Ok...

I presume this is by design, since the doxygen comment for that function includes:

 * @param $client
 *   Either the nid or the client title

This function will break if there are two clients with the same title in an Aegir system. Admittedly an edge case, but wouldn't it be better to use the internal name for this function?

sfyn’s picture

sfyn CreditAttribution: sfyn commented
Issue tags: +API

tagging as an API issue

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Assigned: Unassigned » anarcat

Bloody hell, I just realized this was my blocker for #1223506: cloning a site looses client site ownership!!!

I'll fixup some new API.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Active » Fixed

i fixed up the API by adding the function hosting_get_client_by_uname($uname) (in 1.x, 2.x will change this).

Automatically closed -- issue fixed for 2 weeks with no activity.