Strict warning: Declaration of views_handler_relationship_groupwise_max::options_submit() [#1198166]

Strict warning: Declaration of views_handler_relationship_groupwise_max::options_submit() should be compatible with that of views_handler::options_submit() in require_once() (line 54 of (site)/sites/all/modules/handlers/views_handler_relationship_groupwise_max.inc).

Which I don't see on my system but heh. I'm just easy-going ;)

Comment	File	Size	Author
#1	1198166.views_.options_submit-declaration-compatible.patch	793 bytes	joachim
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joachim CreditAttribution: joachim commented 23 June 2011 at 19:51

Status:

Active

» Needs review

File	Size
1198166.views_.options_submit-declaration-compatible.patch	793 bytes

Comment #2

drew reece CreditAttribution: drew reece commented 23 June 2011 at 21:16

Status:

Needs review

» Reviewed & tested by the community

The patch in #1 and patch # in http://drupal.org/node/1198156
Fixed the issues noted in http://drupal.org/node/1198200

Thanks.
Does 1 person count as a community of testers? :^)

Comment #3

joachim CreditAttribution: joachim commented 23 June 2011 at 21:28

For small patches, absolutely! Thanks :)

(More generally, it depends on a combination of the complexity of the patch and the patch maker and the maintainer. I know for some complex issues I'll say as a maintainer I'd like two reviews.)

Comment #4

drew reece CreditAttribution: drew reece commented 24 June 2011 at 13:06

Is this patch actually in the 7.x-3.x branch?
I have git pulled a few times but I still see the error below, git log doesn't show the fix.

Strict warning: Declaration of views_handler_relationship_groupwise_max::options_submit() should be compatible [error]
with that of views_handler::options_submit() in require_once() (line 54 of
(site)/sites/all/modules/views/handlers/views_handler_relationship_groupwise_max.inc).

Applying the patch #1198166 makes it work fine.