Strict warning: Declaration of views_handler_relationship_groupwise_max::options_submit() should be compatible with that of views_handler::options_submit() in require_once() (line 54 of (site)/sites/all/modules/handlers/views_handler_relationship_groupwise_max.inc).

Which I don't see on my system but heh. I'm just easy-going ;)

CommentFileSizeAuthor
#1 1198166.views_.options_submit-declaration-compatible.patch793 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1198166.views_.options_submit-declaration-compatible.patch793 bytes
drew reece’s picture

drew reece commented
Status: Needs review » Reviewed & tested by the community

The patch in #1 and patch # in http://drupal.org/node/1198156
Fixed the issues noted in http://drupal.org/node/1198200

Thanks.
Does 1 person count as a community of testers? :^)

joachim’s picture

joachim commented

For small patches, absolutely! Thanks :)

(More generally, it depends on a combination of the complexity of the patch and the patch maker and the maintainer. I know for some complex issues I'll say as a maintainer I'd like two reviews.)

drew reece’s picture

drew reece commented

Is this patch actually in the 7.x-3.x branch?
I have git pulled a few times but I still see the error below, git log doesn't show the fix.

Strict warning: Declaration of views_handler_relationship_groupwise_max::options_submit() should be compatible [error]
with that of views_handler::options_submit() in require_once() (line 54 of
(site)/sites/all/modules/views/handlers/views_handler_relationship_groupwise_max.inc).

Applying the patch #1198166 makes it work fine.

joachim’s picture

joachim commented

Not yet; it's only in once a maintainer changes the status to 'fixed' :)

drew reece’s picture

drew reece commented

Aha, that makes sense.
Thank you Joachim

joachim’s picture

joachim commented

More info: http://drupal.org/node/156119

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Looks fine. Commited to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.